public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/activate fs.c Date: Sun, 12 Feb 2012 20:17:00 -0000 [thread overview] Message-ID: <20120212201713.15967.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2012-02-12 20:17:12 Modified files: lib/activate : fs.c Log message: give standard error message if lstat fails unexpectedly Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/fs.c.diff?cvsroot=lvm2&r1=1.65&r2=1.66 --- LVM2/lib/activate/fs.c 2012/02/08 10:43:42 1.65 +++ LVM2/lib/activate/fs.c 2012/02/12 20:17:12 1.66 @@ -225,7 +225,6 @@ static int _rm_link(const char *dev_dir, const char *vg_name, const char *lv_name, int check_udev) { - int r; struct stat buf; static char lv_path[PATH_MAX]; @@ -235,14 +234,17 @@ return 0; } - if ((r = lstat(lv_path, &buf)) && errno == ENOENT) - return 1; - else if (dm_udev_get_sync_support() && udev_checking() && check_udev) + if (lstat(lv_path, &buf)) { + if (errno == ENOENT) + return 1; + log_sys_error("lstat", lv_path); + return 0; + } else if (dm_udev_get_sync_support() && udev_checking() && check_udev) log_warn("The link %s should have been removed by udev " "but it is still present. Falling back to " "direct link removal.", lv_path); - if (r || !S_ISLNK(buf.st_mode)) { + if (!S_ISLNK(buf.st_mode)) { log_error("%s not symbolic link - not removing", lv_path); return 0; }
next reply other threads:[~2012-02-12 20:17 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-12 20:17 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2009-08-05 9:12 prajnoha 2009-08-04 21:44 agk 2009-08-03 18:31 agk 2004-04-14 18:10 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120212201713.15967.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).