public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2/tools vgchange.c
@ 2009-12-07 19:32 wysochanski
  0 siblings, 0 replies; 6+ messages in thread
From: wysochanski @ 2009-12-07 19:32 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski@sourceware.org	2009-12-07 19:32:28

Modified files:
	tools          : vgchange.c 

Log message:
	Fix activated/deactivated log_verbose message
	
	I see "Deactivated" message when I activate and "Activated" message when
	I deactivate.  The code uses "activate" as boolean but it can be any one
	of the enum values from CHANGE_AY, CHANGE_AN, CHANGE_AE, etc.
	
	Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
	Acked-by: Dave Wysochanski <dwysocha@redhat.com>

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.91&r2=1.92

--- LVM2/tools/vgchange.c	2009/11/24 16:08:49	1.91
+++ LVM2/tools/vgchange.c	2009/12/07 19:32:28	1.92
@@ -104,8 +104,8 @@
 
 	if (expected_count)
 		log_verbose("%s %d logical volumes in volume group %s",
-			    activate ? "Activated" : "Deactivated",
-			    count, vg->name);
+			    (activate == CHANGE_AN || activate == CHANGE_ALN)?
+			    "Deactivated" : "Activated", count, vg->name);
 
 	return (expected_count != count) ? ECMD_FAILED : ECMD_PROCESSED;
 }


^ permalink raw reply	[flat|nested] 6+ messages in thread

* LVM2/tools vgchange.c
@ 2011-10-22 16:47 zkabelac
  0 siblings, 0 replies; 6+ messages in thread
From: zkabelac @ 2011-10-22 16:47 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-10-22 16:47:23

Modified files:
	tools          : vgchange.c 

Log message:
	Ensure thin LVs take an exclusive activation

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.123&r2=1.124

--- LVM2/tools/vgchange.c	2011/09/14 18:20:04	1.123
+++ LVM2/tools/vgchange.c	2011/10/22 16:47:23	1.124
@@ -145,7 +145,10 @@
 				stack;
 				continue;
 			}
-		} else if (lv_is_origin(lv) || (activate == CHANGE_AE)) {
+		} else if (lv_is_origin(lv) ||
+			   lv_is_thin_pool(lv) ||
+			   lv_is_thin_volume(lv) ||
+			   (activate == CHANGE_AE)) {
 			if (!activate_lv_excl(cmd, lv)) {
 				stack;
 				continue;


^ permalink raw reply	[flat|nested] 6+ messages in thread

* LVM2/tools vgchange.c
@ 2010-07-26 19:03 wysochanski
  0 siblings, 0 replies; 6+ messages in thread
From: wysochanski @ 2010-07-26 19:03 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski@sourceware.org	2010-07-26 19:03:29

Modified files:
	tools          : vgchange.c 

Log message:
	Remove unneeded "active" variable in vgchange_monitoring().

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.109&r2=1.110

--- LVM2/tools/vgchange.c	2010/07/09 15:34:48	1.109
+++ LVM2/tools/vgchange.c	2010/07/26 19:03:29	1.110
@@ -160,9 +160,9 @@
 
 static int _vgchange_monitoring(struct cmd_context *cmd, struct volume_group *vg)
 {
-	int active, monitored;
+	int monitored;
 
-	if ((active = lvs_in_vg_activated(vg)) &&
+	if (lvs_in_vg_activated(vg) &&
 	    dmeventd_monitor_mode() != DMEVENTD_MONITOR_IGNORE) {
 		monitored = _monitor_lvs_in_vg(cmd, vg, dmeventd_monitor_mode());
 		log_print("%d logical volume(s) in volume group "


^ permalink raw reply	[flat|nested] 6+ messages in thread

* LVM2/tools vgchange.c
@ 2010-06-28 21:35 wysochanski
  0 siblings, 0 replies; 6+ messages in thread
From: wysochanski @ 2010-06-28 21:35 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski@sourceware.org	2010-06-28 21:35:00

Modified files:
	tools          : vgchange.c 

Log message:
	Fix compile warning in vgchange.c regarding mda_copies initialization.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.106&r2=1.107

--- LVM2/tools/vgchange.c	2010/06/28 20:37:37	1.106
+++ LVM2/tools/vgchange.c	2010/06/28 21:35:00	1.107
@@ -528,7 +528,7 @@
 static int _vgchange_metadata_copies(struct cmd_context *cmd,
 				     struct volume_group *vg)
 {
-	uint32_t mda_copies;
+	uint32_t mda_copies = DEFAULT_VGMETADATACOPIES;
 
 	if (arg_count(cmd, vgmetadatacopies_ARG))
 		mda_copies = arg_uint_value(cmd, vgmetadatacopies_ARG,


^ permalink raw reply	[flat|nested] 6+ messages in thread

* LVM2/tools vgchange.c
@ 2010-06-23 10:23 zkabelac
  0 siblings, 0 replies; 6+ messages in thread
From: zkabelac @ 2010-06-23 10:23 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2010-06-23 10:22:59

Modified files:
	tools          : vgchange.c 

Log message:
	Fix typo: premitted ->  permitted
	
	Signed-off-by: Takahiro Yasui<tyasui@redhat.com>

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.104&r2=1.105

--- LVM2/tools/vgchange.c	2010/05/24 09:03:39	1.104
+++ LVM2/tools/vgchange.c	2010/06/23 10:22:59	1.105
@@ -627,7 +627,7 @@
 
 	if ((arg_count(cmd, ignorelockingfailure_ARG) ||
 	     arg_count(cmd, sysinit_ARG)) && !arg_count(cmd, available_ARG)) {
-		log_error("Only -a premitted with --ignorelockingfailure and --sysinit");
+		log_error("Only -a permitted with --ignorelockingfailure and --sysinit");
 		return EINVALID_CMD_LINE;
 	}
 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* LVM2/tools vgchange.c
@ 2009-09-30 12:05 prajnoha
  0 siblings, 0 replies; 6+ messages in thread
From: prajnoha @ 2009-09-30 12:05 UTC (permalink / raw)
  To: lvm-devel, lvm2-cvs

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	prajnoha@sourceware.org	2009-09-30 12:05:26

Modified files:
	tools          : vgchange.c 

Log message:
	Just a cleanup from previous commit. We don't need pvname local var in _activate_lvs_in_vg anymore...

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.87&r2=1.88

--- LVM2/tools/vgchange.c	2009/09/29 20:22:35	1.87
+++ LVM2/tools/vgchange.c	2009/09/30 12:05:25	1.88
@@ -56,7 +56,6 @@
 {
 	struct lv_list *lvl;
 	struct logical_volume *lv;
-	const char *pvname;
 	int count = 0;
 
 	dm_list_iterate_items(lvl, &vg->lvs) {


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-10-22 16:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-07 19:32 LVM2/tools vgchange.c wysochanski
  -- strict thread matches above, loose matches on Subject: below --
2011-10-22 16:47 zkabelac
2010-07-26 19:03 wysochanski
2010-06-28 21:35 wysochanski
2010-06-23 10:23 zkabelac
2009-09-30 12:05 prajnoha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).