public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: snitzer@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/libdm libdm-deptree.c Date: Tue, 05 Jan 2010 21:06:00 -0000 [thread overview] Message-ID: <20100105210626.23371.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: snitzer@sourceware.org 2010-01-05 21:06:26 Modified files: libdm : libdm-deptree.c Log message: Return error to dm_tree_deactivate_children() callers. Otherwise deactivate_lv can fail silently. Signed-off-by: Mike Snitzer <snitzer@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-deptree.c.diff?cvsroot=lvm2&r1=1.66&r2=1.67 --- LVM2/libdm/libdm-deptree.c 2010/01/05 21:05:40 1.66 +++ LVM2/libdm/libdm-deptree.c 2010/01/05 21:06:26 1.67 @@ -1006,6 +1006,7 @@ const char *uuid_prefix, size_t uuid_prefix_len) { + int r = 1; void *handle = NULL; struct dm_tree_node *child = dnode; struct dm_info info; @@ -1043,14 +1044,16 @@ log_error("Unable to deactivate %s (%" PRIu32 ":%" PRIu32 ")", name, info.major, info.minor); + r = 0; continue; } if (dm_tree_node_num_children(child, 0)) - dm_tree_deactivate_children(child, uuid_prefix, uuid_prefix_len); + if (!dm_tree_deactivate_children(child, uuid_prefix, uuid_prefix_len)) + return_0; } - return 1; + return r; } void dm_tree_skip_lockfs(struct dm_tree_node *dnode)
next reply other threads:[~2010-01-05 21:06 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-05 21:06 snitzer [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-15 20:03 agk 2012-05-15 14:10 agk 2012-03-04 16:05 zkabelac 2012-03-02 21:53 zkabelac 2012-01-25 8:46 zkabelac 2012-01-19 15:22 zkabelac 2011-11-04 12:39 zkabelac 2011-10-30 22:04 zkabelac 2011-10-28 20:11 zkabelac 2011-10-20 10:39 zkabelac 2011-10-20 10:35 zkabelac 2011-10-19 16:45 zkabelac 2011-10-19 16:41 zkabelac 2011-10-17 14:15 zkabelac 2011-10-17 14:14 zkabelac 2011-10-03 18:29 zkabelac 2011-09-29 8:51 zkabelac 2011-07-08 19:13 agk 2011-06-22 12:56 prajnoha 2011-06-11 12:55 agk 2011-06-09 15:53 mbroz 2010-11-29 12:42 zkabelac 2010-11-29 11:26 zkabelac 2010-05-25 8:40 zkabelac 2010-04-07 23:51 agk 2010-04-07 21:25 agk 2010-01-15 16:00 jbrassow 2010-01-05 21:05 snitzer 2010-01-05 21:04 snitzer 2009-09-22 16:27 jbrassow 2009-07-07 16:36 agk 2008-12-12 18:45 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100105210626.23371.qmail@sourceware.org \ --to=snitzer@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).