public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/metadata mirror.c Date: Wed, 23 Jun 2010 13:57:00 -0000 [thread overview] Message-ID: <20100623135729.10042.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2010-06-23 13:57:26 Modified files: lib/metadata : mirror.c Log message: The function that runs to compress a stacked mirror after converting from 2-way to 3-way mirror (collapse_mirrored_lv) was calling '_remove_mirror_images' with the 'remove_log' parameter set. When the code was put in to fix 599898 to honor log parameters during conversion, this argument was suddenly being honored. Thus, when someone would convert from a 2-way to 3-way mirror, the log would get removed. 'collapse_mirrored_lv' should not be calling '_remove_mirror_images' with 'remove_log' set. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.119&r2=1.120 --- LVM2/lib/metadata/mirror.c 2010/06/21 16:12:34 1.119 +++ LVM2/lib/metadata/mirror.c 2010/06/23 13:57:26 1.120 @@ -1038,7 +1038,7 @@ if (!_remove_mirror_images(mirror_seg->lv, mirror_seg->area_count - 1, - _no_removable_images, NULL, 1, 1, NULL)) { + _no_removable_images, NULL, 0, 1, NULL)) { log_error("Failed to release mirror images"); return 0; }
next reply other threads:[~2010-06-23 13:57 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-06-23 13:57 jbrassow [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-01 15:05 agk 2011-09-19 14:28 jbrassow 2011-09-16 16:41 jbrassow 2011-09-14 9:54 zkabelac 2011-09-14 4:10 jbrassow 2011-09-13 18:11 jbrassow 2011-06-24 23:39 agk 2011-04-12 14:13 zkabelac 2011-03-24 12:28 mornfall 2011-01-11 17:21 jbrassow 2010-07-09 17:57 jbrassow 2010-04-20 12:14 agk 2010-04-01 14:54 agk 2010-01-08 10:50 zkabelac 2009-12-17 15:59 mornfall 2009-12-09 19:43 mbroz 2009-11-19 13:42 mornfall 2009-11-19 12:09 mornfall 2009-11-18 18:23 mornfall 2009-10-14 14:55 jbrassow 2009-04-23 16:43 mornfall 2008-09-19 4:30 agk 2008-09-19 0:20 agk 2008-01-17 13:37 agk 2008-01-16 19:50 agk 2008-01-16 19:38 agk 2008-01-16 19:11 agk 2008-01-16 19:09 agk 2006-11-10 20:15 agk 2004-05-05 18:35 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100623135729.10042.qmail@sourceware.org \ --to=jbrassow@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).