public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mornfall@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/metadata mirror.c Date: Thu, 24 Mar 2011 12:28:00 -0000 [thread overview] Message-ID: <20110324122803.12121.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mornfall@sourceware.org 2011-03-24 12:28:02 Modified files: lib/metadata : mirror.c Log message: In some cases, we could end up with a mirrored LV without a MIRRORED flag. In other cases, the code could wind up removing wrong number of mirrors. In yet other cases, we could remove the right number of mirrors, but fail to respect the removal preferences (i.e. keep an image that was requested to be removed while removing an image that was requested to be kept). Under some circumstances, remove_mirror_images could also get stuck in an infinite loop. This patch should fix all of the above undesirable behaviours. Signed-off-by: Petr Rockai <prockai@redhat.com> Reviewed-by: Jonathan Brassow <jbrassow@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.144&r2=1.145 --- LVM2/lib/metadata/mirror.c 2011/03/11 14:56:56 1.144 +++ LVM2/lib/metadata/mirror.c 2011/03/24 12:28:02 1.145 @@ -779,7 +779,7 @@ int (*is_removable)(struct logical_volume *, void *), void *removable_baton, unsigned remove_log, unsigned collapse, - uint32_t *removed) + uint32_t *removed, int preferred_only) { uint32_t m; int32_t s; @@ -791,12 +791,13 @@ uint32_t new_area_count = mirrored_seg->area_count; struct lv_list *lvl; struct dm_list tmp_orphan_lvs; + int orig_removed = num_removed; if (removed) *removed = 0; - log_very_verbose("Reducing mirror set from %" PRIu32 " to %" - PRIu32 " image(s)%s.", + log_very_verbose("Reducing mirror set %s from %" PRIu32 " to %" + PRIu32 " image(s)%s.", lv->name, old_area_count, old_area_count - num_removed, remove_log ? " and no log volume" : ""); @@ -805,12 +806,14 @@ return 0; } + num_removed = 0; + /* Move removable_pvs to end of array */ for (s = mirrored_seg->area_count - 1; - s >= 0 && old_area_count - new_area_count < num_removed; + s >= 0 && old_area_count - new_area_count < orig_removed; s--) { sub_lv = seg_lv(mirrored_seg, s); - if (!is_temporary_mirror_layer(sub_lv) && + if (!(is_temporary_mirror_layer(sub_lv) && lv_mirror_count(sub_lv) != 1) && is_removable(sub_lv, removable_baton)) { /* * Check if the user is trying to pull the @@ -824,10 +827,14 @@ } if (!shift_mirror_images(mirrored_seg, s)) return_0; - new_area_count--; + --new_area_count; + ++num_removed; } } + if (!preferred_only) + num_removed = orig_removed; + /* * If removable_pvs were specified, then they have been shifted * to the end to ensure they are removed. The remaining balance @@ -864,12 +871,19 @@ detached_log_lv = detach_mirror_log(mirrored_seg); if (!remove_layer_from_lv(lv, temp_layer_lv)) return_0; - lv->status &= ~MIRRORED; - lv->status &= ~MIRROR_NOTSYNCED; if (collapse && !_merge_mirror_images(lv, &tmp_orphan_lvs)) { log_error("Failed to add mirror images"); return 0; } + /* + * No longer a mirror? Even though new_area_count was 1, + * _merge_mirror_images may have resulted into lv being still a + * mirror. Fix up the flags if we only have one image left. + */ + if (lv_mirror_count(lv) == 1) { + lv->status &= ~MIRRORED; + lv->status &= ~MIRROR_NOTSYNCED; + } mirrored_seg = first_seg(lv); if (remove_log && !detached_log_lv) detached_log_lv = detach_mirror_log(mirrored_seg); @@ -1035,7 +1049,7 @@ *removed = old_area_count - new_area_count; log_very_verbose("%" PRIu32 " image(s) removed from %s", - old_area_count - num_removed, lv->name); + old_area_count - new_area_count, lv->name); return 1; } @@ -1051,6 +1065,9 @@ uint32_t existing_mirrors = lv_mirror_count(lv); struct logical_volume *next_lv = lv; + int preferred_only = 1; + int retries = 0; + num_removed = existing_mirrors - num_mirrors; /* num_removed can be 0 if the function is called just to remove log */ @@ -1062,17 +1079,33 @@ if (!_remove_mirror_images(next_lv, removed_once, is_removable, removable_baton, - remove_log, 0, &r)) + remove_log, 0, &r, preferred_only)) return_0; - if (r < removed_once) { + if (r < removed_once || !removed_once) { /* Some mirrors are removed from the temporary mirror, * but the temporary layer still exists. * Down the stack and retry for remainder. */ next_lv = find_temporary_mirror(next_lv); + if (!next_lv) { + preferred_only = 0; + next_lv = lv; + } } num_removed -= r; + + /* + * if there are still images to be removed, try again; this is + * required since some temporary layers may have been reduced + * to 1, at which point they are made removable, just like + * normal images + */ + if (!next_lv && !preferred_only && !retries && num_removed) { + ++retries; + preferred_only = 1; + } + } while (next_lv && num_removed); if (num_removed) { @@ -1126,7 +1159,7 @@ if (!_remove_mirror_images(mirror_seg->lv, mirror_seg->area_count - 1, - _no_removable_images, NULL, 0, 1, NULL)) { + _no_removable_images, NULL, 0, 1, NULL, 0)) { log_error("Failed to release mirror images"); return 0; } @@ -1252,7 +1285,7 @@ r = _remove_mirror_images(mirrored_seg->lv, old_num_mirrors - num_mirrors, is_mirror_image_removable, removable_pvs, - remove_log, 0, NULL); + remove_log, 0, NULL, 0); if (!r) /* Unable to remove bad devices */ return 0;
next reply other threads:[~2011-03-24 12:28 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-03-24 12:28 mornfall [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-01 15:05 agk 2011-09-19 14:28 jbrassow 2011-09-16 16:41 jbrassow 2011-09-14 9:54 zkabelac 2011-09-14 4:10 jbrassow 2011-09-13 18:11 jbrassow 2011-06-24 23:39 agk 2011-04-12 14:13 zkabelac 2011-01-11 17:21 jbrassow 2010-07-09 17:57 jbrassow 2010-06-23 13:57 jbrassow 2010-04-20 12:14 agk 2010-04-01 14:54 agk 2010-01-08 10:50 zkabelac 2009-12-17 15:59 mornfall 2009-12-09 19:43 mbroz 2009-11-19 13:42 mornfall 2009-11-19 12:09 mornfall 2009-11-18 18:23 mornfall 2009-10-14 14:55 jbrassow 2009-04-23 16:43 mornfall 2008-09-19 4:30 agk 2008-09-19 0:20 agk 2008-01-17 13:37 agk 2008-01-16 19:50 agk 2008-01-16 19:38 agk 2008-01-16 19:11 agk 2008-01-16 19:09 agk 2006-11-10 20:15 agk 2004-05-05 18:35 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110324122803.12121.qmail@sourceware.org \ --to=mornfall@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).