public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: mbroz@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW tools/pvremove.c tools/toollib.c
Date: Thu, 19 Aug 2010 23:04:00 -0000 [thread overview]
Message-ID: <20100819230438.25296.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz@sourceware.org 2010-08-19 23:04:38
Modified files:
. : WHATS_NEW
tools : pvremove.c toollib.c
Log message:
Remove assumption that --yes must be used only in --force mode
This is not only undocumented but is is also in violation with --help
documentation.
Using --yes without --force is useful in pvcreate when it detects
old signature.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1713&r2=1.1714
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.28&r2=1.29
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.207&r2=1.208
--- LVM2/WHATS_NEW 2010/08/19 23:03:34 1.1713
+++ LVM2/WHATS_NEW 2010/08/19 23:04:37 1.1714
@@ -1,6 +1,7 @@
Version 2.02.74 -
==================================
Simplify MD/swap signature detection in pvcreate and allow aborting.
+ Remove assumption that --yes must be used only in --force mode.
Version 2.02.73 - 18th August 2010
==================================
--- LVM2/tools/pvremove.c 2010/07/09 15:34:48 1.28
+++ LVM2/tools/pvremove.c 2010/08/19 23:04:37 1.29
@@ -143,11 +143,6 @@
return EINVALID_CMD_LINE;
}
- if (arg_count(cmd, yes_ARG) && !arg_count(cmd, force_ARG)) {
- log_error("Option y can only be given with option f");
- return EINVALID_CMD_LINE;
- }
-
for (i = 0; i < argc; i++) {
r = pvremove_single(cmd, argv[i], NULL);
if (r > ret)
--- LVM2/tools/toollib.c 2010/06/30 20:03:53 1.207
+++ LVM2/tools/toollib.c 2010/08/19 23:04:37 1.208
@@ -1344,11 +1344,6 @@
return 0;
}
- if (arg_count(cmd, yes_ARG) && !arg_count(cmd, force_ARG)) {
- log_error("Option y can only be given with option f");
- return 0;
- }
-
pp->yes = arg_count(cmd, yes_ARG);
pp->force = arg_count(cmd, force_ARG);
reply other threads:[~2010-08-19 23:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819230438.25296.qmail@sourceware.org \
--to=mbroz@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).