public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: prajnoha@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/misc/lvm-string.c Date: Mon, 20 Sep 2010 14:25:00 -0000 [thread overview] Message-ID: <20100920142528.16716.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: prajnoha@sourceware.org 2010-09-20 14:25:27 Modified files: . : WHATS_NEW lib/misc : lvm-string.c Log message: Revert to old glibc behaviour for vsnprintf used in emit_to_buffer function. Revert to old glibc behaviour for vsnprintf used in emit_to_buffer fn. Otherwise, the check that follows would be wrong for new glibc versions. This caused the rh bug #633033 to be undetected and pass throught the check, corrupting the metadata! Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1730&r2=1.1731 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/misc/lvm-string.c.diff?cvsroot=lvm2&r1=1.20&r2=1.21 --- LVM2/WHATS_NEW 2010/09/20 14:23:20 1.1730 +++ LVM2/WHATS_NEW 2010/09/20 14:25:27 1.1731 @@ -1,5 +1,6 @@ Version 2.02.74 - ================================== + Revert to old glibc behaviour for vsnprintf used in emit_to_buffer function. Use dynamic allocation for metadata's tag buffer (removes 4096 char. limit). Add random suffix to archive file names to prevent races when being created. Reinitialize archive and backup handling on toolcontext refresh. --- LVM2/lib/misc/lvm-string.c 2010/04/23 14:16:33 1.20 +++ LVM2/lib/misc/lvm-string.c 2010/09/20 14:25:27 1.21 @@ -27,6 +27,14 @@ n = vsnprintf(*buffer, *size, fmt, ap); va_end(ap); + /* + * Revert to old glibc behaviour (version <= 2.0.6) where snprintf + * returned -1 if buffer was too small. From glibc 2.1 it returns number + * of chars that would have been written had there been room. + */ + if (n < 0 || ((unsigned) n + 1 > *size)) + n = -1; + if (n < 0 || ((size_t)n == *size)) return 0;
next reply other threads:[~2010-09-20 14:25 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-09-20 14:25 prajnoha [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-03-13 23:18 zkabelac 2011-03-13 22:57 zkabelac 2010-09-28 1:29 agk 2004-10-11 15:59 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100920142528.16716.qmail@sourceware.org \ --to=prajnoha@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).