public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/misc/lvm-string.c Date: Sun, 13 Mar 2011 22:57:00 -0000 [thread overview] Message-ID: <20110313225751.12383.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-03-13 22:57:51 Modified files: . : WHATS_NEW lib/misc : lvm-string.c Log message: Fix buffer allocation size for uuid string We have 3 components and traling '\0' so allocate proper room for all of them. Problem was nicely hidden by allocation from pool and allocation aligment offset - so to trigger real problem with this one is actually hard. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1952&r2=1.1953 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/misc/lvm-string.c.diff?cvsroot=lvm2&r1=1.24&r2=1.25 --- LVM2/WHATS_NEW 2011/03/13 22:52:16 1.1952 +++ LVM2/WHATS_NEW 2011/03/13 22:57:51 1.1953 @@ -1,5 +1,6 @@ Version 2.02.85 - =================================== + Fix buffer allocation in build_dm_uuid(). Fix readlink usage inside get_primary_dev(). Use format instance mempool where possible and adequate. Call destroy_instance for any PVs found in VG structure during vg_free call. --- LVM2/lib/misc/lvm-string.c 2010/11/17 10:19:30 1.24 +++ LVM2/lib/misc/lvm-string.c 2011/03/13 22:57:51 1.25 @@ -229,7 +229,7 @@ if (!layer) layer = ""; - len = sizeof(UUID_PREFIX) + strlen(lvid) + strlen(layer) + 1; + len = sizeof(UUID_PREFIX) + strlen(lvid) + strlen(layer) + 1 + 1; if (!(dmuuid = dm_pool_alloc(mem, len))) { log_error("build_dm_name: Allocation failed for %" PRIsize_t
next reply other threads:[~2011-03-13 22:57 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-03-13 22:57 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-03-13 23:18 zkabelac 2010-09-28 1:29 agk 2010-09-20 14:25 prajnoha 2004-10-11 15:59 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110313225751.12383.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).