public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/libdm libdm-common.c
Date: Mon, 29 Nov 2010 10:11:00 -0000 [thread overview]
Message-ID: <20101129101152.29135.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2010-11-29 10:11:51
Modified files:
libdm : libdm-common.c
Log message:
Cleanup remove test for NULL
dm_free is testing NULL itself
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-common.c.diff?cvsroot=lvm2&r1=1.101&r2=1.102
--- LVM2/libdm/libdm-common.c 2010/10/15 01:10:28 1.101
+++ LVM2/libdm/libdm-common.c 2010/11/29 10:11:50 1.102
@@ -250,10 +250,8 @@
char path[PATH_MAX];
struct stat st1, st2;
- if (dmt->dev_name) {
- dm_free(dmt->dev_name);
- dmt->dev_name = NULL;
- }
+ dm_free(dmt->dev_name);
+ dmt->dev_name = NULL;
/*
* Path supplied for existing device?
@@ -292,8 +290,7 @@
if (strlen(name) >= DM_NAME_LEN) {
log_error("Name \"%s\" too long", name);
- if (new_name)
- dm_free(new_name);
+ dm_free(new_name);
return 0;
}
@@ -309,10 +306,7 @@
int dm_task_set_uuid(struct dm_task *dmt, const char *uuid)
{
- if (dmt->uuid) {
- dm_free(dmt->uuid);
- dmt->uuid = NULL;
- }
+ dm_free(dmt->uuid);
if (!(dmt->uuid = dm_strdup(uuid))) {
log_error("dm_task_set_uuid: strdup(%s) failed", uuid);
next reply other threads:[~2010-11-29 10:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 10:11 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-13 14:39 zkabelac
2012-01-25 21:47 zkabelac
2011-09-24 11:47 prajnoha
2011-07-08 15:34 agk
2011-07-05 16:17 agk
2011-06-28 9:24 agk
2011-03-02 8:40 zkabelac
2010-12-13 12:44 prajnoha
2010-12-13 12:30 prajnoha
2010-12-13 12:18 prajnoha
2009-09-25 19:06 agk
2009-09-25 18:19 agk
2009-09-25 18:13 agk
2009-09-11 16:11 prajnoha
2009-09-11 15:57 prajnoha
2009-08-06 15:00 prajnoha
2009-08-05 19:50 agk
2009-08-03 18:33 agk
2009-08-03 11:01 agk
2009-07-31 16:57 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129101152.29135.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).