public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/libdm libdm-common.c Date: Tue, 28 Jun 2011 09:24:00 -0000 [thread overview] Message-ID: <20110628092414.16758.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2011-06-28 09:24:14 Modified files: libdm : libdm-common.c Log message: more fixes to readahead etc. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-common.c.diff?cvsroot=lvm2&r1=1.120&r2=1.121 --- LVM2/libdm/libdm-common.c 2011/06/27 22:38:53 1.120 +++ LVM2/libdm/libdm-common.c 2011/06/28 09:24:13 1.121 @@ -864,13 +864,6 @@ char *pos; /* - * Clear warn_if_udev_failed if rely_on_udev is set. It doesn't get - * checked in this case - this just removes the flag from log messages. - */ - if (rely_on_udev) - warn_if_udev_failed = 0; - - /* * Note: warn_if_udev_failed must have valid content */ if ((type == NODE_DEL) && _other_node_ops(type)) @@ -911,10 +904,16 @@ */ dm_list_iterate_safe(noph, nopht, &_node_ops) { nop = dm_list_item(noph, struct node_op_parms); - if (!strcmp(old_name, nop->dev_name)) + if (!strcmp(old_name, nop->dev_name)) { _log_node_op("Unstacking", nop); _del_node_op(nop); + } } + else if (type == NODE_READ_AHEAD) { + /* udev doesn't process readahead */ + rely_on_udev = 0; + warn_if_udev_failed = 0; + } if (!(nop = dm_malloc(sizeof(*nop) + len))) { log_error("Insufficient memory to stack mknod operation"); @@ -930,9 +929,14 @@ nop->mode = mode; nop->read_ahead = read_ahead; nop->read_ahead_flags = read_ahead_flags; - nop->warn_if_udev_failed = warn_if_udev_failed; nop->rely_on_udev = rely_on_udev; + /* + * Clear warn_if_udev_failed if rely_on_udev is set. It doesn't get + * checked in this case - this just removes the flag from log messages. + */ + nop->warn_if_udev_failed = rely_on_udev ? 0 : warn_if_udev_failed; + _store_str(&pos, &nop->dev_name, dev_name); _store_str(&pos, &nop->old_name, old_name);
next reply other threads:[~2011-06-28 9:24 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-28 9:24 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-13 14:39 zkabelac 2012-01-25 21:47 zkabelac 2011-09-24 11:47 prajnoha 2011-07-08 15:34 agk 2011-07-05 16:17 agk 2011-03-02 8:40 zkabelac 2010-12-13 12:44 prajnoha 2010-12-13 12:30 prajnoha 2010-12-13 12:18 prajnoha 2010-11-29 10:11 zkabelac 2009-09-25 19:06 agk 2009-09-25 18:19 agk 2009-09-25 18:13 agk 2009-09-11 16:11 prajnoha 2009-09-11 15:57 prajnoha 2009-08-06 15:00 prajnoha 2009-08-05 19:50 agk 2009-08-03 18:33 agk 2009-08-03 11:01 agk 2009-07-31 16:57 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110628092414.16758.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).