LVM2 lib/commands/toolcontext.c ./WHATS_NEW

LVM2 lib/commands/toolcontext.c ./WHATS_NEW

[zkabelac]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2010-11-29 10:58:33

Modified files:
	lib/commands   : toolcontext.c 
	.              : WHATS_NEW 

Log message:
	Fix check for empty system_dir
	
	Fixing check for zero length system_dir string.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/commands/toolcontext.c.diff?cvsroot=lvm2&r1=1.109&r2=1.110
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1810&r2=1.1811

--- LVM2/lib/commands/toolcontext.c	2010/11/24 09:34:35	1.109
+++ LVM2/lib/commands/toolcontext.c	2010/11/29 10:58:32	1.110
@@ -1036,7 +1036,7 @@
 	char default_dir[PATH_MAX];
 	const char *dir;
 
-	if (!cmd->system_dir) {
+	if (!cmd->system_dir[0]) {
 		log_warn("WARNING: Metadata changes will NOT be backed up");
 		backup_init(cmd, "", 0);
 		archive_init(cmd, "", 0, 0, 0);
--- LVM2/WHATS_NEW	2010/11/25 17:16:41	1.1810
+++ LVM2/WHATS_NEW	2010/11/29 10:58:33	1.1811
@@ -1,5 +1,6 @@
 Version 2.02.78 - 
 ====================================
+  Fix test for empty system_dir string in _init_backup().
   Certain lvconvert invocations are now required to be done in two steps.
   Fix missing context desctruction in err path of lvm1 fallback in lvm2_main().
   Fix memory leak in error path of parse_loop_device_name() from dmsetup.

LVM2 lib/commands/toolcontext.c ./WHATS_NEW

[wysochanski]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski@sourceware.org	2010-06-01 21:47:57

Modified files:
	lib/commands   : toolcontext.c 
	.              : WHATS_NEW 

Log message:
	Revert _init_rand() to reset errno - restores original init behavior.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/commands/toolcontext.c.diff?cvsroot=lvm2&r1=1.99&r2=1.100
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1602&r2=1.1603

--- LVM2/lib/commands/toolcontext.c	2010/06/01 21:46:29	1.99
+++ LVM2/lib/commands/toolcontext.c	2010/06/01 21:47:57	1.100
@@ -1084,10 +1084,13 @@
 
 static void _init_rand(struct cmd_context *cmd)
 {
-	if (read_urandom(&cmd->rand_seed, sizeof(cmd->rand_seed)))
+	if (read_urandom(&cmd->rand_seed, sizeof(cmd->rand_seed))) {
+		reset_lvm_errno(1);
 		return;
+	}
 
 	cmd->rand_seed = (unsigned) time(NULL) + (unsigned) getpid();
+	reset_lvm_errno(1);
 }
 
 static void _init_globals(struct cmd_context *cmd)
--- LVM2/WHATS_NEW	2010/06/01 19:02:12	1.1602
+++ LVM2/WHATS_NEW	2010/06/01 21:47:57	1.1603
@@ -1,5 +1,6 @@
 Version 2.02.67 -
 ===============================
+  Do not fail lvm_init() if init_logging() or _init_rand() generates an errno.
   Don't merge unchanged persistent cache file before dumping if tool scanned.
   Fix incorrect memory pool deallocation while using vg_read for files.
   Add --type parameter description to the lvcreate man page.