LVM2 ./WHATS_NEW tools/pvremove.c

LVM2 ./WHATS_NEW tools/pvremove.c

[agk]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2011-02-28 19:35:10

Modified files:
	.              : WHATS_NEW 
	tools          : pvremove.c 

Log message:
	Improve pvremove error message when PV belongs to a VG.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1929&r2=1.1930
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.32&r2=1.33

--- LVM2/WHATS_NEW	2011/02/28 13:19:02	1.1929
+++ LVM2/WHATS_NEW	2011/02/28 19:35:09	1.1930
@@ -1,5 +1,6 @@
 Version 2.02.85 - 
 ===================================
+  Improve pvremove error message when PV belongs to a VG.
   Extend normal policy to allow mirror logs on same PVs as images if necessary.
   Improve cling policy to recognise PVs already used during the transaction.
   Improve normal allocation algorithm to include clinging to existing areas.
--- LVM2/tools/pvremove.c	2011/02/21 12:16:00	1.32
+++ LVM2/tools/pvremove.c	2011/02/28 19:35:10	1.33
@@ -64,8 +64,8 @@
 	/* Allow partial & exported VGs to be destroyed. */
 	/* we must have -ff to overwrite a non orphan */
 	if (arg_count(cmd, force_ARG) < 2) {
-		log_error("Can't pvremove physical volume \"%s\" of "
-			  "volume group \"%s\" without -ff", name, pv_vg_name(pv));
+		log_error("PV %s belongs to Volume Group %s so please use vgreduce first.", name, pv_vg_name(pv));
+		log_error("(If you are certain you need pvremove, then confirm by using --force twice.)");
 		return 0;
 	}
 

LVM2 ./WHATS_NEW tools/pvremove.c

[agk]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2006-12-13 18:40:23

Modified files:
	.              : WHATS_NEW 
	tools          : pvremove.c 

Log message:
	Add missing pvremove error message when device doesn't exist.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.520&r2=1.521
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.11&r2=1.12

--- LVM2/WHATS_NEW	2006/12/13 03:39:57	1.520
+++ LVM2/WHATS_NEW	2006/12/13 18:40:22	1.521
@@ -1,5 +1,6 @@
 Version 2.02.17 -
 ===================================
+  Add missing pvremove error message when device doesn't exist.
   When lvconvert allocates a mirror log, respect parallel area constraints.
   Use loop to iterate through the now-ordered policy list in _allocate().
   Check for failure to allocate just the mirror log.
--- LVM2/tools/pvremove.c	2006/11/17 02:45:51	1.11
+++ LVM2/tools/pvremove.c	2006/12/13 18:40:23	1.12
@@ -38,8 +38,8 @@
 	if (!(pv = pv_read(cmd, name, NULL, NULL, 1))) {
 		if (arg_count(cmd, force_ARG))
 			return 1;
-		else
-			return 0;
+		log_error("Physical Volume %s not found", name);
+		return 0;
 	}
 
 	/* orphan ? */

LVM2 ./WHATS_NEW tools/pvremove.c

[agk]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2006-11-17 02:45:52

Modified files:
	.              : WHATS_NEW 
	tools          : pvremove.c 

Log message:
	Fix pvremove error path for case when PV is in use.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.499&r2=1.500
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.10&r2=1.11

--- LVM2/WHATS_NEW	2006/11/16 17:36:00	1.499
+++ LVM2/WHATS_NEW	2006/11/17 02:45:51	1.500
@@ -1,5 +1,6 @@
 Version 2.02.15 -
 ====================================
+  Fix pvremove error path for case when PV is in use.
   Warn if certain duplicate config file entries are seen.
   Enhance lvm_dump.sh for sysreport integration and add man page.
   Fix --autobackup argument which could never disable backups.
--- LVM2/tools/pvremove.c	2006/05/09 21:23:51	1.10
+++ LVM2/tools/pvremove.c	2006/11/17 02:45:51	1.11
@@ -92,9 +92,9 @@
 	}
 
 	if (!dev_test_excl(dev)) {
-		log_error("Can't open %s exclusively.  Mounted filesystem?",
-			  dev_name(dev));
-		return 0;
+		log_error("Can't open %s exclusively - not removing. "
+			  "Mounted filesystem?", dev_name(dev));
+		goto error;
 	}
 
 	/* Wipe existing label(s) */

LVM2 ./WHATS_NEW tools/pvremove.c

[agk]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk@sourceware.org	2006-04-05 22:24:16

Modified files:
	.              : WHATS_NEW 
	tools          : pvremove.c 

Log message:
	pvremove without -f now fails if there's no PV label.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.351&r2=1.352
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.8&r2=1.9