public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/lib activate/activate.c metadata/mirror.c
Date: Fri, 17 Jun 2011 14:24:00 -0000 [thread overview]
Message-ID: <20110617142418.4686.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2011-06-17 14:24:18
Modified files:
lib/activate : activate.c
lib/metadata : mirror.c
Log message:
Add couple FIXMEs around suspicious code
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/activate.c.diff?cvsroot=lvm2&r1=1.200&r2=1.201
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.152&r2=1.153
--- LVM2/lib/activate/activate.c 2011/06/17 14:22:48 1.200
+++ LVM2/lib/activate/activate.c 2011/06/17 14:24:18 1.201
@@ -795,12 +795,14 @@
goto out;
}
+ /* FIXME: Is this fallback alright? */
if (activate_lv_excl(lv->vg->cmd, lv)) {
if (!deactivate_lv(lv->vg->cmd, lv))
stack;
+ /* FIXME: locally & exclusive are undefined. */
return 0;
}
-
+ /* FIXME: Check exclusive value here. */
out:
if (locally)
*locally = l;
--- LVM2/lib/metadata/mirror.c 2011/06/11 00:03:07 1.152
+++ LVM2/lib/metadata/mirror.c 2011/06/17 14:24:18 1.153
@@ -2020,6 +2020,7 @@
}
if (vg_is_clustered(lv->vg)) {
+ /* FIXME: review check of lv_is_active_remotely */
if (!(lv->status & ACTIVATE_EXCL) &&
!cluster_mirror_is_available(lv)) {
log_error("Shared cluster mirrors are not available.");
reply other threads:[~2011-06-17 14:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110617142418.4686.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).