public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
* LVM2 daemons/cmirrord/cluster.c ./WHATS_NEW
@ 2011-09-06 18:15 zkabelac
0 siblings, 0 replies; only message in thread
From: zkabelac @ 2011-09-06 18:15 UTC (permalink / raw)
To: lvm-devel, lvm2-cvs
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2011-09-06 18:15:43
Modified files:
daemons/cmirrord: cluster.c
. : WHATS_NEW
Log message:
Fix memory leak of allocated bitmap in error path
Found by static analyzer.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/cmirrord/cluster.c.diff?cvsroot=lvm2&r1=1.16&r2=1.17
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2091&r2=1.2092
--- LVM2/daemons/cmirrord/cluster.c 2010/10/25 12:59:24 1.16
+++ LVM2/daemons/cmirrord/cluster.c 2011/09/06 18:15:43 1.17
@@ -619,6 +619,7 @@
if (rv != SA_AIS_OK) {
LOG_ERROR("[%s] Failed to open checkpoint: %s",
SHORT_UUID(entry->name.value), str_ais_error(rv));
+ free(bitmap);
return -EIO; /* FIXME: better error */
}
@@ -647,6 +648,7 @@
if (rv != SA_AIS_OK) {
LOG_ERROR("[%s] Sync checkpoint section creation failed: %s",
SHORT_UUID(entry->name.value), str_ais_error(rv));
+ free(bitmap);
return -EIO; /* FIXME: better error */
}
--- LVM2/WHATS_NEW 2011/09/06 18:11:21 1.2091
+++ LVM2/WHATS_NEW 2011/09/06 18:15:43 1.2092
@@ -1,5 +1,6 @@
Version 2.02.89 -
==================================
+ Fix error path bitmap leak in cmirrord import_checkpoint().
Log unlink() error in cmirrord remove_lockfile().
Remove incorrect requirement for -j or -m from lvchange error message.
Fix unsafe table load when splitting off smaller mirror from a larger one.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-09-06 18:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-06 18:15 LVM2 daemons/cmirrord/cluster.c ./WHATS_NEW zkabelac
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).