LVM2 ./WHATS_NEW lib/misc/lvm-exec.c

LVM2 ./WHATS_NEW lib/misc/lvm-exec.c

[zkabelac]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-09-19 12:48:02

Modified files:
	.              : WHATS_NEW 
	lib/misc       : lvm-exec.c 

Log message:
	Move debug message
	
	so it does not look like we are executing command in the middle of
	critical_section in log trace.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2116&r2=1.2117
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/misc/lvm-exec.c.diff?cvsroot=lvm2&r1=1.13&r2=1.14

--- LVM2/WHATS_NEW	2011/09/16 14:40:06	1.2116
+++ LVM2/WHATS_NEW	2011/09/19 12:48:02	1.2117
@@ -1,5 +1,6 @@
 Version 2.02.89 - 
 ==================================
+  Move debug message in exec_cmd after sync_local_dev_names.
   Fix clvmd processing of invalid request on local socket.
   Fix command line option decoding.
   Reset LV status when unlinking LV from VG.
--- LVM2/lib/misc/lvm-exec.c	2011/08/04 14:30:51	1.13
+++ LVM2/lib/misc/lvm-exec.c	2011/09/19 12:48:02	1.14
@@ -54,7 +54,6 @@
 	int status;
 	char buf[PATH_MAX * 2];
 
-	log_verbose("Executing: %s", _verbose_args(argv, buf, sizeof(buf)));
 
 	if (rstatus)
 		*rstatus = -1;
@@ -63,6 +62,8 @@
 		if (!sync_local_dev_names(cmd)) /* Flush ops and reset dm cookie */
 			return_0;
 
+	log_verbose("Executing: %s", _verbose_args(argv, buf, sizeof(buf)));
+
 	if ((pid = fork()) == -1) {
 		log_error("fork failed: %s", strerror(errno));
 		return 0;

LVM2 ./WHATS_NEW lib/misc/lvm-exec.c

[zkabelac]

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-09-19 14:54:23

Modified files:
	.              : WHATS_NEW 
	lib/misc       : lvm-exec.c 

Log message:
	Use log_error instead of log_verbose when executed command fails

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2121&r2=1.2122
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/misc/lvm-exec.c.diff?cvsroot=lvm2&r1=1.14&r2=1.15

--- LVM2/WHATS_NEW	2011/09/19 14:52:33	1.2121
+++ LVM2/WHATS_NEW	2011/09/19 14:54:23	1.2122
@@ -1,5 +1,6 @@
 Version 2.02.89 - 
 ==================================
+  Use log_error instead of log_verbose when executed command fails.
   Add support for non /dev device paths into fsadm script.
   Support different PATH setting for fsadm script testing.
   Surround all executed commands with quotes in fsadm script.
--- LVM2/lib/misc/lvm-exec.c	2011/09/19 12:48:02	1.14
+++ LVM2/lib/misc/lvm-exec.c	2011/09/19 14:54:23	1.15
@@ -96,7 +96,7 @@
 	if (WEXITSTATUS(status)) {
 		if (rstatus) {
 			*rstatus = WEXITSTATUS(status);
-			log_verbose("%s failed: %u", argv[0], *rstatus);
+			log_error("%s failed: %u", argv[0], *rstatus);
 		} else
 			log_error("%s failed: %u", argv[0], WEXITSTATUS(status));
 		return 0;