public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW_DM libdm/libdm-deptree.c Date: Mon, 03 Oct 2011 18:28:00 -0000 [thread overview] Message-ID: <20111003182828.1779.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-10-03 18:28:26 Modified files: . : WHATS_NEW_DM libdm : libdm-deptree.c Log message: Update error path tracing for _resume_node dm_task_create & dm_task_set_name produces it's own log_error Add missing stacks for dm_task_set_cookie, dm_task_run, dm_task_get_info. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.508&r2=1.509 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-deptree.c.diff?cvsroot=lvm2&r1=1.116&r2=1.117 --- LVM2/WHATS_NEW_DM 2011/09/29 08:53:48 1.508 +++ LVM2/WHATS_NEW_DM 2011/10/03 18:28:25 1.509 @@ -1,5 +1,6 @@ Version 1.02.68 - ================================== + Update debug logging for _resume_node. Add functions to support thin provisioning target (API unstable). Improve libdm-config error path reporting. Update dmsetup resume man with --addnodeonresume/create options. --- LVM2/libdm/libdm-deptree.c 2011/10/03 18:26:07 1.116 +++ LVM2/libdm/libdm-deptree.c 2011/10/03 18:28:25 1.117 @@ -1127,13 +1127,13 @@ log_verbose("Resuming %s (%" PRIu32 ":%" PRIu32 ")", name, major, minor); if (!(dmt = dm_task_create(DM_DEVICE_RESUME))) { - log_error("Suspend dm_task creation failed for %s", name); + log_debug("Suspend dm_task creation failed for %s.", name); return 0; } /* FIXME Kernel should fill in name on return instead */ if (!dm_task_set_name(dmt, name)) { - log_error("Failed to set readahead device name for %s", name); + log_debug("Failed to set device name for %s resumption.", name); goto out; } @@ -1149,13 +1149,16 @@ log_error("Failed to set read ahead"); if (!dm_task_set_cookie(dmt, cookie, udev_flags)) - goto out; + goto_out; - if ((r = dm_task_run(dmt))) { - if (already_suspended) - dec_suspended(); - r = dm_task_get_info(dmt, newinfo); - } + if (!(r = dm_task_run(dmt))) + goto_out; + + if (already_suspended) + dec_suspended(); + + if (!(r = dm_task_get_info(dmt, newinfo))) + stack; out: dm_task_destroy(dmt);
next reply other threads:[~2011-10-03 18:28 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-10-03 18:28 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-15 21:27 agk 2012-02-10 14:48 zkabelac 2012-02-10 14:42 zkabelac 2012-01-25 21:50 zkabelac 2011-10-17 13:15 mbroz 2011-10-14 13:34 zkabelac 2011-09-07 8:37 zkabelac 2011-02-18 16:13 zkabelac 2009-07-03 12:46 agk 2008-12-11 16:25 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20111003182828.1779.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).