public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/thin thin.c Date: Thu, 06 Oct 2011 11:06:00 -0000 [thread overview] Message-ID: <20111006110637.32681.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-10-06 11:06:36 Modified files: lib/thin : thin.c Log message: Add more validation to config parser Do not leave it for vgvalidate(). Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/thin/thin.c.diff?cvsroot=lvm2&r1=1.14&r2=1.15 --- LVM2/lib/thin/thin.c 2011/10/03 18:26:07 1.14 +++ LVM2/lib/thin/thin.c 2011/10/06 11:06:36 1.15 @@ -76,6 +76,11 @@ if (!dm_config_get_uint32(sn, "data_block_size", &seg->data_block_size)) return SEG_LOG_ERROR("Could not read data_block_size"); + if ((seg->data_block_size < DM_THIN_MIN_DATA_SIZE) || + (seg->data_block_size > DM_THIN_MAX_DATA_SIZE)) + return SEG_LOG_ERROR("Unsupported value %u for data_block_size", + seg->device_id); + if (dm_config_has_node(sn, "zero_new_blocks") && !dm_config_get_uint32(sn, "zero_new_blocks", &seg->zero_new_blocks)) return SEG_LOG_ERROR("Could not read zero_new_blocks for"); @@ -168,6 +173,10 @@ if (!dm_config_get_uint32(sn, "device_id", &seg->device_id)) return SEG_LOG_ERROR("Could not read device_id for"); + if (seg->device_id > DM_THIN_MAX_DEVICE_ID) + return SEG_LOG_ERROR("Unsupported value %u for device_id", + seg->device_id); + return 1; }
next reply other threads:[~2011-10-06 11:06 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-10-06 11:06 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-01-19 15:42 zkabelac 2011-12-21 12:56 zkabelac 2011-11-03 14:37 zkabelac 2011-10-28 20:25 zkabelac 2011-10-22 16:45 zkabelac 2011-10-20 10:32 zkabelac 2011-10-20 10:30 zkabelac 2011-10-17 14:17 zkabelac 2011-10-11 8:51 zkabelac 2011-09-06 22:35 zkabelac 2011-09-01 10:16 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20111006110637.32681.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).