public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/thin thin.c Date: Thu, 20 Oct 2011 10:30:00 -0000 [thread overview] Message-ID: <20111020103039.29421.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-10-20 10:30:39 Modified files: lib/thin : thin.c Log message: Print low_water_mark only when it has some value Do not expose low_water_mark in mda yet, if it has no use. We do not allow to be set via current lvm tool code. Usage needs to be clarified first. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/thin/thin.c.diff?cvsroot=lvm2&r1=1.19&r2=1.20 --- LVM2/lib/thin/thin.c 2011/10/20 10:28:41 1.19 +++ LVM2/lib/thin/thin.c 2011/10/20 10:30:39 1.20 @@ -113,7 +113,8 @@ if (!dm_config_get_uint64(sn, "transaction_id", &seg->transaction_id)) return SEG_LOG_ERROR("Could not read transaction_id for"); - if (!dm_config_get_uint64(sn, "low_water_mark", &seg->low_water_mark)) + if (dm_config_has_node(sn, "low_water_mark") && + !dm_config_get_uint64(sn, "low_water_mark", &seg->low_water_mark)) return SEG_LOG_ERROR("Could not read low_water_mark"); if (!dm_config_get_uint32(sn, "data_block_size", &seg->data_block_size)) @@ -154,9 +155,11 @@ outf(f, "pool = \"%s\"", seg_lv(seg, 0)->name); outf(f, "metadata = \"%s\"", seg->pool_metadata_lv->name); outf(f, "transaction_id = %" PRIu64, seg->transaction_id); - outf(f, "low_water_mark = %" PRIu64, seg->low_water_mark); outf(f, "data_block_size = %d", seg->data_block_size); + if (seg->low_water_mark) + outf(f, "low_water_mark = %" PRIu64, seg->low_water_mark); + if (seg->zero_new_blocks) outf(f, "zero_new_blocks = 1");
next reply other threads:[~2011-10-20 10:30 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-10-20 10:30 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-01-19 15:42 zkabelac 2011-12-21 12:56 zkabelac 2011-11-03 14:37 zkabelac 2011-10-28 20:25 zkabelac 2011-10-22 16:45 zkabelac 2011-10-20 10:32 zkabelac 2011-10-17 14:17 zkabelac 2011-10-11 8:51 zkabelac 2011-10-06 11:06 zkabelac 2011-09-06 22:35 zkabelac 2011-09-01 10:16 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20111020103039.29421.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).