public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/tools lvchange.c toollib.c
Date: Thu, 03 Nov 2011 14:59:00 -0000	[thread overview]
Message-ID: <20111103145921.1089.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-11-03 14:59:20

Modified files:
	tools          : lvchange.c toollib.c 

Log message:
	Thin removing limitation on activation of pool device.
	
	Since activation of pool is now independent on thin activation,
	user may do whatever he needs - thought preferable thin should stay alive,
	but it it will be found inactivate, update_pool will bring the pool up.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvchange.c.diff?cvsroot=lvm2&r1=1.134&r2=1.135
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.232&r2=1.233

--- LVM2/tools/lvchange.c	2011/11/03 14:41:18	1.134
+++ LVM2/tools/lvchange.c	2011/11/03 14:59:20	1.135
@@ -534,12 +534,6 @@
 		return ECMD_FAILED;
 	}
 
-	if (lv_is_used_thin_pool(lv) &&
-	    (arg_count(cmd, available_ARG))) {
-		log_error("Can't change pool volume \"%s\".", lv->name);
-		return ECMD_FAILED;
-	}
-
 	if (lv_is_cow(lv) && !lv_is_virtual_origin(origin_from_cow(lv)) &&
 	    arg_count(cmd, available_ARG)) {
 		log_error("Can't change snapshot logical volume \"%s\"",
--- LVM2/tools/toollib.c	2011/10/28 20:28:01	1.232
+++ LVM2/tools/toollib.c	2011/11/03 14:59:20	1.233
@@ -126,11 +126,6 @@
 		if (lv_is_virtual_origin(lvl->lv) && !arg_count(cmd, all_ARG))
 			continue;
 
-		/* Only unused thin pool can change its availability */
-		if (!lvargs_supplied && lv_is_used_thin_pool(lvl->lv) &&
-		    arg_count(cmd, available_ARG))
-			continue;
-
 		/*
 		 * Only let hidden LVs through it --all was used or the LVs 
 		 * were specifically named on the command line.


                 reply	other threads:[~2011-11-03 14:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111103145921.1089.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).