public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW lib/metadata/lv.c
Date: Mon, 27 Feb 2012 11:13:00 -0000	[thread overview]
Message-ID: <20120227111349.28272.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2012-02-27 11:13:48

Modified files:
	.              : WHATS_NEW 
	lib/metadata   : lv.c 

Log message:
	Fix missing break
	
	Bug introduced with addition of internal error default case.
	Seem like this code is not used.
	TODO: add coverage test.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2314&r2=1.2315
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/lv.c.diff?cvsroot=lvm2&r1=1.38&r2=1.39

--- LVM2/WHATS_NEW	2012/02/27 10:15:08	1.2314
+++ LVM2/WHATS_NEW	2012/02/27 11:13:48	1.2315
@@ -1,5 +1,6 @@
 Version 2.02.94 - 
 ====================================
+  Fix missing break in _format_pvsegs (2.02.92).
   Test seg pointer for non-null it in raid_target_percent error path.
   Check for errors in _init_tags() during config loading.
   Always check result of _set_vg_name() in lvcreate.
--- LVM2/lib/metadata/lv.c	2012/02/23 22:31:23	1.38
+++ LVM2/lib/metadata/lv.c	2012/02/27 11:13:48	1.39
@@ -53,6 +53,7 @@
 		case AREA_UNASSIGNED:
 			name = "unassigned";
 			extent = 0;
+			break;
 		default:
 			log_error(INTERNAL_ERROR "Unknown area segtype.");
 			return NULL;


             reply	other threads:[~2012-02-27 11:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-27 11:13 zkabelac [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-01-20 10:55 zkabelac
2011-09-23 15:17 jbrassow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120227111349.28272.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).