public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: crawley@sources.redhat.com
Cc: mauve-discuss@sources.redhat.com
Subject: Re: mauve ./ChangeLog gnu/testlet/java/lang/Charac ...
Date: Mon, 12 Apr 2004 12:15:00 -0000	[thread overview]
Message-ID: <1081772102.13170.567.camel@elsschot.wildebeest.org> (raw)
In-Reply-To: <20040408160537.21917.qmail@sources.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

Hi Stephen,

On Thu, 2004-04-08 at 18:05, crawley@sources.redhat.com wrote:
> 	Fixed java.lang.Character.unicode test to match JDK 1.4 semantics

Nice cleanup!
One thing that seems to be missing though is the CharInfo.decimalDigit
field. Without such a field the code will not compile. But it seems we
don't use that field during the tests either. Should I add the following
or did you have something else in mind?

diff -u -r1.3 CharInfo.java
--- gnu/testlet/java/lang/Character/CharInfo.java       4 Feb 1999 18:46:19 -0000       1.3
+++ gnu/testlet/java/lang/Character/CharInfo.java       12 Apr 2004 12:12:44 -0000
@@ -29,6 +29,7 @@
 {
   public String name;
   public String category;
+  public int decimalDigit;
   public int digit;
   public int numericValue;
   public char uppercase;

With that it compiles again and java.lang.Character.unicode gives
0 of 3578944 tests failed for GNU Classpath :)

Cheers,

Mark

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

       reply	other threads:[~2004-04-12 12:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20040408160537.21917.qmail@sources.redhat.com>
2004-04-12 12:15 ` Mark Wielaard [this message]
2004-04-12 23:26   ` Stephen Crawley
2004-04-13 23:13   ` Stephen Crawley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1081772102.13170.567.camel@elsschot.wildebeest.org \
    --to=mark@klomp.org \
    --cc=crawley@sources.redhat.com \
    --cc=mauve-discuss@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).