public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Jeroen Frijters <jeroen@sumatra.nl>
Cc: Andrew Haley <aph@redhat.com>,
	Thomas Zander <zander@javalobby.org>,
	 mauve-discuss@sources.redhat.com
Subject: RE: Some issues..
Date: Sun, 25 Apr 2004 11:10:00 -0000	[thread overview]
Message-ID: <1082891420.27234.1377.camel@elsschot.wildebeest.org> (raw)
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADEA3@LEMBU.sumatrasoftware.com>


[-- Attachment #1.1: Type: text/plain, Size: 1982 bytes --]

Hi,

On Fri, 2004-04-23 at 11:11, Jeroen Frijters wrote:
> Mark Wielaard wrote:
> > On Fri, 2004-04-16 at 14:03, Andrew Haley wrote:
> > > Mark Wielaard writes:
> > >  > Ehe, how do you use/invoke it?
> > > 
> > > It gets invoked automatically when you run Mauve, at least on my
> > > system.  BinaryCompatibilityTest.java is the driver that invokes it.
> > 
> > Aha. And it uses Runtime.exec()... Which wasn't properly 
> > implemented in GNU Classpath proper. But we have it now (almost)!
> > 
> > ow that I can run it I see that kaffe, jamvm and gij all fail most of
> > the tests. Each of IL bin_01 till IL bin_18 fails 5 or 6 times giving:
> > 107 of 125 tests failed
> 
> I never really payed attention to this test, but now I see that it is
> *nix specific (using shell script <shiver>).
> 
> What is the policy for Mauve? I realise most of you don't care about/for
> Windows, but personally I do. So I support Mark's earlier
> suggestion/request to move this to a separate section.

There is always Cygwin <http://cygwin.com/>
But I do think it might be better to separate out this test from the
rest of Mauve proper. On the other hand, if you have a non-GNUish/Posix
system then you can always disable this one test. Separating it out
without a mechanism for running the tests on multiple systems isn't
really worth it I guess.

> On a somewhat related note, the invalid_port test in DatagramSocketTest2
> assumes that it is illegal to create a DatagramSocket that listens on
> port 21, but I don't believe that is part of the Java specification.

I believe you are right. It is only an issue for processes without
enough privileges on some systems (which normally reserve all post
between 0 and 1024 for "system" services). So I committed this patch:

2004-04-25  Mark Wielaard  <mark@klomp.org>

       * gnu/testlet/java/net/DatagramSocket/DatagramSocketTest2.java: Remove
       RESERVED_PORT (21) test.

Cheers,

Mark


[-- Attachment #1.2: patch --]
[-- Type: text/x-patch, Size: 1319 bytes --]

Index: gnu/testlet/java/net/DatagramSocket/DatagramSocketTest2.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/net/DatagramSocket/DatagramSocketTest2.java,v
retrieving revision 1.5
diff -u -r1.5 DatagramSocketTest2.java
--- gnu/testlet/java/net/DatagramSocket/DatagramSocketTest2.java	29 Oct 2003 14:39:20 -0000	1.5
+++ gnu/testlet/java/net/DatagramSocket/DatagramSocketTest2.java	25 Apr 2004 11:08:51 -0000
@@ -59,7 +59,6 @@
 {
 	final static int INVALID_PORT = -1;
 	final static int ECHO_PORT = 7;
-	final static int RESERVED_PORT = 21;
 	final static int GOOD_PORT = 37777;
 	final static int MAX_PORT = 65535;
 
@@ -93,25 +92,6 @@
 	public void invalid_port()
 	{
 		harness.checkPoint("invalid_port");
-		try
-		{
-			DatagramSocket sock = new DatagramSocket(RESERVED_PORT);
-			errormsg("invalid_port", 1, true, "BindException");
-		}
-		catch (BindException e)
-		{
-			harness.check(true);
-		}
-		catch (SocketException e)
-		{
-			errormsg("invalid_port", 1, false, "SocketException");
-		}
-		catch (NullPointerException e)
-		{
-			errormsg("invalid_port", 1, false, "NullPointerException");
-			e.printStackTrace();
-		}
-
 		try
 		{
 			DatagramSocket sock = new DatagramSocket(INVALID_PORT);

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2004-04-25 11:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-23  9:12 Jeroen Frijters
2004-04-25 11:10 ` Mark Wielaard [this message]
2004-04-29 11:41   ` Andrew Haley
2004-04-29 13:16     ` Thomas
2004-04-29 15:29       ` Andrew Haley
2004-05-01  9:49         ` Thomas Zander
2004-05-02 12:27           ` Andrew Haley
  -- strict thread matches above, loose matches on Subject: below --
2004-04-03 13:05 Thomas Zander
2004-04-03 13:16 ` Andrew Haley
2004-04-03 13:41   ` Thomas Zander
2004-04-03 15:42     ` Andrew Haley
2004-04-03 16:06       ` Thomas Zander
2004-04-15 22:22       ` Mark Wielaard
2004-04-16  9:31         ` Andrew Haley
2004-04-16 11:29           ` Mark Wielaard
2004-04-16 12:04             ` Andrew Haley
2004-04-22 21:41               ` Mark Wielaard
2004-04-15 22:14 ` Mark Wielaard
2004-05-07 11:54 ` John Leuner
2004-05-07 13:25   ` Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1082891420.27234.1377.camel@elsschot.wildebeest.org \
    --to=mark@klomp.org \
    --cc=aph@redhat.com \
    --cc=jeroen@sumatra.nl \
    --cc=mauve-discuss@sources.redhat.com \
    --cc=zander@javalobby.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).