Re: Some issues..

[Thomas Zander <zander@javalobby.org>]

[-- Attachment #1: Type: Text/Plain, Size: 2814 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 03 April 2004 15:15, Andrew Haley wrote:
> Thomas Zander writes:
>  > Next CVS does not compile with suns javac
>  > (gnu/testlet/java/text/SimpleDateFormat/attribute.java)
>
> Would you please help us here by sending a patch?

It seems the author used some illegal constructs; I'm not sure what he meant
so I'll send the error messages instead.

    [javac] Compiling 678 source files to /home/zander/sources/java/mauve/build
    [javac] /home/zander/sources/java/mauve/gnu/testlet/java/text/SimpleDateFormat/attribute.java:160: illegal start of expression
    [javac]     static Format.Field[] fields = new Format.Field[] {
    [javac]         ^
    [javac] /home/zander/sources/java/mauve/gnu/testlet/java/text/SimpleDateFormat/attribute.java:165: illegal start of expression
    [javac]     static int[] begin = new int[] {
    [javac]         ^
    [javac] /home/zander/sources/java/mauve/gnu/testlet/java/text/SimpleDateFormat/attribute.java:168: illegal start of expression
    [javac]     static int[] end = new int[] {

I don't think these 'static' modifiers are needed in the first place; but why were
they added?

Second; I found at least one directory that contains java files without a
package; leading it to be uncompilable (due to duplicate class names)
I found:
gnu/testlet/BinaryCompatibility/altered/
Should those have package lines??

>  > Please make the project seem 'less dead' to the passing eye!!  If
>  > Red-hat does not do anything; what about moving the project to
>  > sourceforge or savannah ??
>
> How would moving the project to a different server help?  Many people
> contribute to Mauve, Red Hat provide the server.

Oh; I did not want to imply mauve can't run on a RedHat server; my intent
was to let you know of the problems. And since I could not imagine being 
the first to notice them I added a suggestion in case the pages on RedHat's
servers were not available to the project members.
Anyway;  Please make the project seem 'less dead' to the passing eye!!

>  > maybe someone here can answer my question posted on the
>  > classpath list a couple of days ago (providing a patch to mauve).
>  > http://mail.gnu.org/archive/html/classpath/2004-04/msg00000.html
>
> It was a very strange patch.  A tarfile with one file that was a diff,
> and a new directory.  However, that patch looks reasonable enough.
> However, there was no ChangeLog entry; we'll need one of those.

I noticed that the patch does not cleanly apply anymore; here is a new diff.

- -- 
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAbr7TCojCW6H2z/QRAu+CAKCiC9VbH6bPq+rfQNga7ekPuLuaDACgwxI9
js0VZsiSLnzzLtIS1DitU20=
=MuJw
-----END PGP SIGNATURE-----

[-- Attachment #2: antCompat.diff --]
[-- Type: text/x-diff, Size: 1185 bytes --]

Index: gnu/testlet/SimpleTestHarness.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/SimpleTestHarness.java,v
retrieving revision 1.38
diff -u -3 -p -r1.38 SimpleTestHarness.java
--- gnu/testlet/SimpleTestHarness.java	29 Aug 2003 14:52:21 -0000	1.38
+++ gnu/testlet/SimpleTestHarness.java	3 Apr 2004 13:36:59 -0000
@@ -50,6 +50,11 @@ public class SimpleTestHarness
 	    " (number " + (count + 1) + ")");
   }
   
+
+  protected int getFailures() {
+    return failures;
+  }
+
   public void check (boolean result)
   {
     if (!result)
Index: ChangeLog
===================================================================
RCS file: /cvs/mauve/mauve/ChangeLog,v
retrieving revision 1.563
diff -u -3 -p -r1.563 ChangeLog
--- ChangeLog	26 Mar 2004 13:32:23 -0000	1.563
+++ ChangeLog	3 Apr 2004 13:37:00 -0000
@@ -1,3 +1,8 @@
+2004-04-03  Thomas Zander <zander@kde.org>
+
+	* added an ant build option so the autotools are not needed if you use
+	a fully functional JVM (for example for writing tests).
+
 2004-03-26  Mark Wielaard  <mark@klomp.org>
 
 	* gnu/testlet/java/io/ObjectInputOutput/Compat2.java: Explicitly set

[-- Attachment #3: antMauve.tgz --]
[-- Type: application/x-tgz, Size: 2538 bytes --]