From: Mark Wielaard <mark@klomp.org>
To: mauve-discuss@sourceware.org
Cc: Pedro Izecksohn <izecksohn@yahoo.com>
Subject: childNodesLength patch update
Date: Tue, 17 Jan 2006 08:08:00 -0000 [thread overview]
Message-ID: <1137485325.8135.38.camel@localhost.localdomain> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 364 bytes --]
Hi,
Pedro noticed that an old boolean variable was still used from an older
revision of the test. This is not needed anymore. So here is the patch
to remove it:
2006-01-17 Pedro Izecksohn <izecksohn@yahoo.com>
* gnu/testlet/org/w3c/dom/childNodesLength.java (passed): Removed.
(checkNode): Don't check passed variable.
Committed,
Mark
[-- Attachment #1.2: childNodesLength-passed.patch --]
[-- Type: text/x-patch, Size: 1076 bytes --]
Index: gnu/testlet/org/w3c/dom/childNodesLength.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/org/w3c/dom/childNodesLength.java,v
retrieving revision 1.1
diff -u -r1.1 childNodesLength.java
--- gnu/testlet/org/w3c/dom/childNodesLength.java 16 Jan 2006 15:15:45 -0000 1.1
+++ gnu/testlet/org/w3c/dom/childNodesLength.java 17 Jan 2006 08:06:24 -0000
@@ -34,7 +34,6 @@
{
TestHarness harness;
- boolean passed;
private void checkNode (Node node)
{
@@ -85,8 +84,6 @@
this.harness=harness;
- passed=true;
-
DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
DocumentBuilder db = null;
@@ -129,15 +126,6 @@
recurse (document.getChildNodes());
- if (passed)
- {
- harness.check (true, "All Node kinds tested implement .getChildNodes().getLength() correctly.");
- }
- else
- {
- harness.fail ("Some Node kind does NOT implement .getChildNodes().getLength() correctly.");
- }
-
}
}
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
reply other threads:[~2006-01-17 8:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137485325.8135.38.camel@localhost.localdomain \
--to=mark@klomp.org \
--cc=izecksohn@yahoo.com \
--cc=mauve-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).