public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
* childNodesLength patch update
@ 2006-01-17  8:08 Mark Wielaard
  0 siblings, 0 replies; only message in thread
From: Mark Wielaard @ 2006-01-17  8:08 UTC (permalink / raw)
  To: mauve-discuss; +Cc: Pedro Izecksohn


[-- Attachment #1.1: Type: text/plain, Size: 364 bytes --]

Hi,

Pedro noticed that an old boolean variable was still used from an older
revision of the test. This is not needed anymore. So here is the patch
to remove it:

2006-01-17  Pedro Izecksohn  <izecksohn@yahoo.com>

    * gnu/testlet/org/w3c/dom/childNodesLength.java (passed): Removed.
    (checkNode): Don't check passed variable.

Committed,

Mark

[-- Attachment #1.2: childNodesLength-passed.patch --]
[-- Type: text/x-patch, Size: 1076 bytes --]

Index: gnu/testlet/org/w3c/dom/childNodesLength.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/org/w3c/dom/childNodesLength.java,v
retrieving revision 1.1
diff -u -r1.1 childNodesLength.java
--- gnu/testlet/org/w3c/dom/childNodesLength.java	16 Jan 2006 15:15:45 -0000	1.1
+++ gnu/testlet/org/w3c/dom/childNodesLength.java	17 Jan 2006 08:06:24 -0000
@@ -34,7 +34,6 @@
 {
 
   TestHarness harness;
-  boolean passed;
 
   private void checkNode (Node node)
   {
@@ -85,8 +84,6 @@
 
     this.harness=harness;
 
-    passed=true;
-
     DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
 
     DocumentBuilder db = null;
@@ -129,15 +126,6 @@
 
     recurse (document.getChildNodes());
 
-    if (passed)
-    {
-      harness.check (true, "All Node kinds tested implement .getChildNodes().getLength() correctly.");
-    }
-    else
-    {
-      harness.fail ("Some Node kind does NOT implement .getChildNodes().getLength() correctly.");
-    }
-
   }
 
 }

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-01-17  8:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-17  8:08 childNodesLength patch update Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).