From: Mark Wielaard <mark@klomp.org>
To: Edwin Steiner <edwin.steiner@gmx.net>
Cc: mauve-discuss@sourceware.org
Subject: Re: misleading output "PASS: Error: ..."
Date: Sun, 22 Jan 2006 17:50:00 -0000 [thread overview]
Message-ID: <1137858855.4418.4.camel@localhost> (raw)
In-Reply-To: <20060120195947.GA8058@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]
Hi Edwin,
On Fri, 2006-01-20 at 20:59 +0100, Edwin Steiner wrote:
> During my work with tgolem I found many lines in the mauve output like
> this:
>
> PASS: gnu.testlet.java.lang.Byte.ByteTest: Error: test_Basics failed - 1 (number 1)
>
> They are produced by such code:
>
> harness.check(!( Byte.MIN_VALUE != -128 ),
> "Error: test_Basics failed - 1" );
>
> Would you accept patches turning this into
>
> harness.check(!( Byte.MIN_VALUE != -128 ),
> "test_Basics - 1" );
>
> ? (Only changing the string. Changing the double negation seems too
> error prone for the many cases I found.)
Yes please! I have found these message strings confusing myself in the
past. If you do decide to change the double negation then please rewrite
these as actual checks:
harness.check(Byte.MIN_VALUE, -128, "test_Basics - 1" );
That way one sees the expected value if the the test would ever fail.
But just changing the message strings would already be an improvement.
Cheers,
Mark
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2006-01-22 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 19:59 Edwin Steiner
2006-01-22 17:50 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137858855.4418.4.camel@localhost \
--to=mark@klomp.org \
--cc=edwin.steiner@gmx.net \
--cc=mauve-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).