public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Sven de Marothy <sven@physto.se>
To: Jeroen Frijters <jeroen@sumatra.nl>
Cc: mauve-discuss@sourceware.org, classpath@gnu.org
Subject: RE: Testing JDK bugs?
Date: Fri, 28 Jul 2006 12:33:00 -0000	[thread overview]
Message-ID: <1154089963.2849.1.camel@qcplx01.physto.se> (raw)
In-Reply-To: <D92197D0A6547B44A1567814F851FA6827A53C@LEMBU.sumatrasoftware.com>

On Fri, 2006-07-28 at 09:56 +0200, Jeroen Frijters wrote:

> Even if something is "Obviously Wrong", it may not be a good idea to fix
> it because it would be a breaking change. For example:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6227069
> 

Obvious? Anyway, IMHO "fixing" something in a compatibility-breaking
way simply isn't a fix at all. It's the opposite. 

However, this goes in the opposite direction as well. And that's when
you really need to make a judgement call. I just did so in the
BigDecimal patch I just commited (which is why I was rude enough to
cross-post it to the main list).

Which is that setScale(scale, rounding) should throw an
ArithmeticException if scale < 0. The spec says so, and the JRE
does so prior to v1.5. In 1.5 it does not (with no change to the doc).

So without thinking too hard I figured it was a 1.5 regression and 
put the exception back in (fixing a mauve regression on our part).
After all, this could break compatibility, in theory.

Although now I'm not quite so sure, because the probable cause
of this is that the divide(BigDecimal, scale, rounding) method
which we (and Sun, presumably) implement this on, shows the same
behaviour, only the docs have changed. 

/Sven

  reply	other threads:[~2006-07-28 12:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-27  9:49 Roman Kennke
2006-07-27 13:08 ` David Gilbert
2006-07-27 14:56   ` Jeroen Frijters
2006-07-27 16:32     ` David Gilbert
2006-07-27 17:01     ` Andrew Haley
2006-07-28  7:56       ` Jeroen Frijters
2006-07-28 12:33         ` Sven de Marothy [this message]
2006-07-28 14:51         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1154089963.2849.1.camel@qcplx01.physto.se \
    --to=sven@physto.se \
    --cc=classpath@gnu.org \
    --cc=jeroen@sumatra.nl \
    --cc=mauve-discuss@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).