public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] BinaryCompatibilty tests fail due to bogus CLASSPATH with kaffe
@ 2004-10-22 19:24 Noa Resare
  2004-10-22 19:27 ` Noa Resare
  2004-10-23 10:07 ` Andrew Haley
  0 siblings, 2 replies; 3+ messages in thread
From: Noa Resare @ 2004-10-22 19:24 UTC (permalink / raw)
  To: Mauve News Group

Hello

When the CLASSPATH environment variable is unset when executing the
BinaryCompatibility tests make sets CLASSPATH to just MAUVE_HOME. The
BinaryCompatibility testing script 'foo' then executes $JAVA without an
explicit -classpath arg which makes tests fail with kaffe.

The attached patch adds an explicit -classpath . to the $JAVA args and
makes cvs kaffe pass all the BinaryCompatibility tests. Please apply.

As usual the patch is also available from
http://resare.com/noa/mauve/patches/ along with my other pending
patches.

/noa

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] BinaryCompatibilty tests fail due to bogus CLASSPATH with kaffe
  2004-10-22 19:24 [PATCH] BinaryCompatibilty tests fail due to bogus CLASSPATH with kaffe Noa Resare
@ 2004-10-22 19:27 ` Noa Resare
  2004-10-23 10:07 ` Andrew Haley
  1 sibling, 0 replies; 3+ messages in thread
From: Noa Resare @ 2004-10-22 19:27 UTC (permalink / raw)
  To: Mauve News Group

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

fre 2004-10-22 klockan 21:24 +0200 skrev Noa Resare:
> The attached patch adds an explicit -classpath . to the $JAVA args and
> makes cvs kaffe pass all the BinaryCompatibility tests. Please apply.

forgot to attach. sorry.

/noa

[-- Attachment #2: mauve-binary-compat.patch --]
[-- Type: text/x-patch, Size: 1229 bytes --]

Index: ChangeLog
===================================================================
RCS file: /cvs/mauve/mauve/ChangeLog,v
retrieving revision 1.708
diff -u -r1.708 ChangeLog
--- ChangeLog	21 Oct 2004 22:05:25 -0000	1.708
+++ ChangeLog	22 Oct 2004 19:23:22 -0000
@@ -1,3 +1,8 @@
+2004-10-22  Noa Resare  <noa@resare.com>
+
+	* gnu/testlet/BinaryCompatibility/foo:
+	added explicit classpath to $JAVA invocation in test script
+
 2004-10-21  Dalibor Topic  <robilad@kaffe.org>
 
 	* gnu/testlet/java/util/zip/InflaterInputStream/basic.java,
Index: gnu/testlet/BinaryCompatibility/foo
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/BinaryCompatibility/foo,v
retrieving revision 1.1
diff -u -r1.1 foo
--- gnu/testlet/BinaryCompatibility/foo	19 Aug 2003 14:48:24 -0000	1.1
+++ gnu/testlet/BinaryCompatibility/foo	22 Oct 2004 19:23:22 -0000
@@ -18,8 +18,8 @@
 done
 objs=`echo $1*.java | sed 's/\.java/.o/g'`
 if test "x$JAVA" != "x" ; then
-    $JAVA $1 > $1.out1 || echo FAIL "$1: "
-    echo $JAVA $1
+    $JAVA -classpath . $1 > $1.out1 || echo FAIL "$1: "
+    echo $JAVA -classpath . $1
 else
     if test "$verbose" = "true" ; then
 	echo $GCJ $objs -o $1 --main=$1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] BinaryCompatibilty tests fail due to bogus CLASSPATH with kaffe
  2004-10-22 19:24 [PATCH] BinaryCompatibilty tests fail due to bogus CLASSPATH with kaffe Noa Resare
  2004-10-22 19:27 ` Noa Resare
@ 2004-10-23 10:07 ` Andrew Haley
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Haley @ 2004-10-23 10:07 UTC (permalink / raw)
  To: Noa Resare; +Cc: Mauve News Group

+2004-10-22  Noa Resare  <noa@resare.com>
+
+	* gnu/testlet/BinaryCompatibility/foo:
+	added explicit classpath to $JAVA invocation in test script
+

OK.

Andrew.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-10-23 10:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-22 19:24 [PATCH] BinaryCompatibilty tests fail due to bogus CLASSPATH with kaffe Noa Resare
2004-10-22 19:27 ` Noa Resare
2004-10-23 10:07 ` Andrew Haley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).