From: Michael Koch <konqueror@gmx.de>
To: "Jeroen Frijters" <jeroen@sumatra.nl>
Cc: <classpath@gnu.org>, "Mauve Discuss" <mauve-discuss@sources.redhat.com>
Subject: Re: java.util.Date mess
Date: Tue, 12 Oct 2004 09:41:00 -0000 [thread overview]
Message-ID: <200410121141.31542.konqueror@gmx.de> (raw)
In-Reply-To: <D92197D0A6547B44A1567814F851FA687E1C@LEMBU.sumatrasoftware.com>
On Tuesday 12 October 2004 11:35, Jeroen Frijters wrote:
> Michael Koch wrote:
> > On Monday 11 October 2004 15:39, Jeroen Frijters wrote:
> > > I have some code that depends on unspecified behavior of
> > > java.util.Date. In the Sun JDK if you pass out of range
> > > parameters to the Date constructors that take year, month,
> > > date, etc. it will automatically convert to a valid date (for
> > > example, new Date(104, 8, 41) is Oct 11, 2004.)
> > >
> > > I have a rather lame patch that addresses this (see below),
> > > would anyone object to this?
> >
> > Are there mauve test that confirm that this breaks nothing ?
>
> I made a new Mauve test (attached) that works better with my patch
> (after I fixed one error in my patch and fixed an additional Date
> bug), but it still fails on three tests. One is due to a bug in
> GregorianCalendar and I haven't investigated the other two.
>
> Is the attached test OK to commit? Do I need to modify any other
> Mauve files to add the test?
Just add the file with a proper ChangeLog entry and be done. Thats all
you need to do. Thanks for the testcase.
Michael
prev parent reply other threads:[~2004-10-12 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-12 9:35 Jeroen Frijters
2004-10-12 9:41 ` Andrew Haley
2004-10-12 9:41 ` Michael Koch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410121141.31542.konqueror@gmx.de \
--to=konqueror@gmx.de \
--cc=classpath@gnu.org \
--cc=jeroen@sumatra.nl \
--cc=mauve-discuss@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).