public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Thomas Zander <TZander@factotummedia.nl>
To: Jeroen Frijters <jeroen@sumatra.nl>
Cc: mauve-discuss@sources.redhat.com
Subject: Re: New runner
Date: Wed, 09 Feb 2005 09:36:00 -0000	[thread overview]
Message-ID: <20050209093601.GA31991@factotummedia.nl> (raw)
In-Reply-To: <D92197D0A6547B44A1567814F851FA6806947C@LEMBU.sumatrasoftware.com>

[-- Attachment #1: Type: text/plain, Size: 2446 bytes --]

On Wed, Feb 09, 2005 at 10:25:03AM +0100, Jeroen Frijters wrote:
> Thomas Zander wrote:
> > Hi, Jeroen. Thanks for your reply.
> > I've just looked into this; when I delete the config and the
> > SimpleTestHarness I get compile errors in (only) 9 tests.
> > The following are easy to fix and run correctly with some 
> > modifications
> > (read: removal of the cast):
> >     gnu/testlet/java/io/FileDescriptor/jdk11.java
> >     gnu/testlet/java/io/FileReader/jdk11.java
> >     gnu/testlet/java/io/FileWriter/jdk11.java
> >     gnu/testlet/java/io/RandomAccessFile/jdk11.java
> > 
> > These are a bit more difficult; but I believe them to be 
> > broken by design or not usable for a 'java -jar' kind of
> > test anyway.
> > I'll be more specific:
> > These 4 tests each test some socket stuff based completely on the
> > assumtion that there is someone (an smtp host) listening on a
> > pre-configured host/port.  This is quite an assumtion that is not very
> > usable in the proposed (portable) test-jar.
> >     gnu/testlet/java/net/Socket/SocketTest.java
> >     gnu/testlet/java/net/Socket/jdk12.java
> >     gnu/testlet/java/net/Socket/jdk13.java
> >     gnu/testlet/java/net/Socket/jdk14.java
> 
> I don't think they're inherently unusable from a jar, I'd like to see a
> gnu.testlet.config version that reads the settings from a properties
> file (or whatever) instead of hardcoding them in the auto dance.

The way the config settings are shipped is not the issue here;  the
question where a socket can connect to that is reachable from the testing
machine so the test does not fail because of wrong reasons is a bigger
problem. And the one I tried to list above.
When we solve that issue then we can think about how to config it.  I have
no idea how to do so; so I'm open to suggestions!

> > The following test tests things like being able to open a 
> > file we ship in mauve (in the same package) and other stuff thats
> > really really basic. (like File.seperator) Quite useless to test
> > in an environment that is shipped in a jar :-)
> >     gnu/testlet/java/io/File/jdk11.java
> 
> This is more tricky to handle, but hopefully we can figure out a way to
> get this test in as well.

When we are actually running this test we already did a 'java -jar' and we
found several classes in that jar.  Does that not imply that the tests in
that class will pass?

-- 
Thomas Zander

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2005-02-09  9:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-09  9:25 Jeroen Frijters
2005-02-09  9:36 ` Thomas Zander [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-02-09  9:48 Jeroen Frijters
2005-02-07  8:55 Jeroen Frijters
2005-02-07 19:41 ` Thomas Zander
2005-02-06 20:27 Thomas Zander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050209093601.GA31991@factotummedia.nl \
    --to=tzander@factotummedia.nl \
    --cc=jeroen@sumatra.nl \
    --cc=mauve-discuss@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).