RE: SeverSocket.toString() not specified

RE: SeverSocket.toString() not specified

[Koster, K.J.]

Dear Mark,

> 
> I have noticed the toString() methods do vary a little bit, do they
> contain a [] around the returned string, do they actually resolve the
> hostname, sometimes there is an extra space somewhere, etc.
> 
> But I agree that if it does not even contain the InetAddress as dotted
> decimals then the user might be very confused. Maybe changing the test
> as follows might be more correct.
> 
>     * gnu/testlet/java/net/ServerSocket/ServerSocketTest.java
>     (test_params): Make toString() tests less strict, just 
> check if they contain the ip number.
>
Hmm... If the tests get messy I'd say just slash it. You're right.

    Kees Jan

=====================================================
 You can't have everything.  Where would you put it?
                                     [Steven Wright]

RE: SeverSocket.toString() not specified

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

Hi,

On Fri, 2002-04-05 at 15:33, Koster, K.J. wrote:

> While I agree that it's not formally specified, I think that the
> representation of IP addresses as strings is pretty much written in stone by
> now. I think it will be safe to assume what the returned format is going to
> be. Anyone writing an implementation of InetAddress that returns the IP
> address for example in hexadecimal notation better make that their #1 FAQ
> item.

I have noticed the toString() methods do vary a little bit, do they
contain a [] around the returned string, do they actually resolve the
hostname, sometimes there is an extra space somewhere, etc.

But I agree that if it does not even contain the InetAddress as dotted
decimals then the user might be very confused. Maybe changing the test
as follows might be more correct.

    * gnu/testlet/java/net/ServerSocket/ServerSocketTest.java
    (test_params): Make toString() tests less strict, just check if they
    contain the ip number.

What do you think?

Cheers,

Mark

[-- Attachment #2: ServerSocketTest.patch2 --]
[-- Type: text/x-patch, Size: 1156 bytes --]

Index: gnu/testlet/java/net/ServerSocket/ServerSocketTest.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/net/ServerSocket/ServerSocketTest.java,v
retrieving revision 1.2
diff -u -r1.2 ServerSocketTest.java
--- ServerSocketTest.java	1999/07/12 16:26:14	1.2
+++ ServerSocketTest.java	2002/04/05 14:23:36
@@ -165,15 +165,13 @@
 
 			}
 			catch ( Exception e ){}
+			
+			String ip = "0.0.0.0";
+			harness.check(sock.toString().indexOf(ip) != -1,
+				"toString() should contain IP");
+			harness.check(sock.getInetAddress().toString().indexOf(ip) != -1,
+				"InetAddress toString() should contain IP");
 
-			if ( !sock.toString().equals(
-"ServerSocket[addr=all-zeros-broadcast/0.0.0.0,port=0,localport=30000]"))
-				harness.fail("Error : test_params failed - 4" + "toString did not return proper values " );
-
-			if ( !sock.getInetAddress().toString().equals(
-			  "all-zeros-broadcast/0.0.0.0"))
-				harness.fail("Error : test_params failed - 5" + "getInetAddress did not return proper values " );
-			  
 			sock.setSocketFactory( null );
 			
 		}

RE: SeverSocket.toString() not specified

[Koster, K.J.]

Dear Mark,

> 
> InetAddress.toString() also does not have a specification of the
> returned String format:
> 	Converts this IP address to a String.
> 
> So I propose to drop both tests.
> 
While I agree that it's not formally specified, I think that the
representation of IP addresses as strings is pretty much written in stone by
now. I think it will be safe to assume what the returned format is going to
be. Anyone writing an implementation of InetAddress that returns the IP
address for example in hexadecimal notation better make that their #1 FAQ
item.

    Kees Jan

=====================================================
 You can't have everything.  Where would you put it?
                                     [Steven Wright]

SeverSocket.toString() not specified

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Hi,

The spec for ServerSocket.toString() only says:
    Returns the implementation address and implementation port of this
    socket as a String.

So no valid test can be made for that method.

InetAddress.toString() also does not have a specification of the
returned String format:
	Converts this IP address to a String.

So I propose to drop both tests.

        * gnu/testlet/java/net/ServerSocket/ServerSocketTest.java
        (test_params): Drop unspecified toString() tests.

Any objections?

Cheers,

Mark

[-- Attachment #2: ServerSocketTest.patch --]
[-- Type: text/x-patch, Size: 903 bytes --]

Index: gnu/testlet/java/net/ServerSocket/ServerSocketTest.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/net/ServerSocket/ServerSocketTest.java,v
retrieving revision 1.2
diff -u -r1.2 ServerSocketTest.java
--- ServerSocketTest.java	1999/07/12 16:26:14	1.2
+++ ServerSocketTest.java	2002/04/05 13:19:33
@@ -166,14 +166,6 @@
 			}
 			catch ( Exception e ){}
 
-			if ( !sock.toString().equals(
-"ServerSocket[addr=all-zeros-broadcast/0.0.0.0,port=0,localport=30000]"))
-				harness.fail("Error : test_params failed - 4" + "toString did not return proper values " );
-
-			if ( !sock.getInetAddress().toString().equals(
-			  "all-zeros-broadcast/0.0.0.0"))
-				harness.fail("Error : test_params failed - 5" + "getInetAddress did not return proper values " );
-			  
 			sock.setSocketFactory( null );
 			
 		}