From: Tom Tromey <tromey@redhat.com>
To: Archie Cobbs <archie@dellroad.org>
Cc: Sascha Brawer <brawer@dandelis.ch>,
mauve-discuss@sources.redhat.com, commit-classpath@gnu.org
Subject: Re: Mauve patch
Date: Wed, 07 Apr 2004 05:45:00 -0000 [thread overview]
Message-ID: <87vfkc4amd.fsf@fleche.redhat.com> (raw)
In-Reply-To: <200404061346.i36DkRdh019920@arch20m.dellroad.org>
>>>>> "Archie" == Archie Cobbs <archie@dellroad.org> writes:
Archie> This patch doesn't guarantee anything, and in general it's impossible
Archie> to make this test "correct" because the spec allows finalization and
Archie> reference enqueuing to happen after arbitrarily long delays.
Yeah, these tests are basically bogus. I thought I had removed them,
but I guess I forgot.
Archie> This patch simply makes the test "correct" for JC (and possibly
Archie> some other VM(s) out there). Since there's no way to *ensure* the
Archie> finalizer and reference enqueing thread(s) have run, we just try
Archie> to give them every opportunity to do so before declaring that their
Archie> work should be done.
I think the patch is fine to go in. It certainly doesn't make the
situation any worse.
Perhaps it is better to just remove the test. Or make a new
"unportable" section of Mauve, since some things seemingly can't be
tested.
Tom
next prev parent reply other threads:[~2004-04-07 5:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200404060330.i363UY1B018067@arch20m.dellroad.org>
2004-04-06 11:52 ` Sascha Brawer
2004-04-06 12:15 ` Ingo Prötel
2004-04-06 14:08 ` Archie Cobbs
2004-04-07 5:45 ` Tom Tromey [this message]
2004-04-07 6:01 ` Stephen Crawley
2004-04-07 14:53 ` Archie Cobbs
2004-04-15 21:04 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vfkc4amd.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=archie@dellroad.org \
--cc=brawer@dandelis.ch \
--cc=commit-classpath@gnu.org \
--cc=mauve-discuss@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).