From: Torben.Nielsen@sagemdenmark.dk
To: mauve-discuss@sourceware.org
Subject: Bug in getEncoding testcase
Date: Tue, 27 Sep 2005 08:20:00 -0000 [thread overview]
Message-ID: <OF4E140155.028ECB38-ONC1257089.002DD37D-C1257089.002DD38E@et.ascom.dk> (raw)
A few weeks ago I posted this patch to mauve-patches. Since it is still
unchanged in cvs, I would like to ask if I posted to the wrong list, or
if there is a problem with the patch. The problem with the existing
testcase
is that contradictory to the test description in the top of the file, it
requires the extended charsets to be present, causing numerous false error
reports.
Index: gnu/testlet/java/io/InputStreamReader/getEncoding.java
===================================================================
RCS file:
/cvs/mauve/mauve/gnu/testlet/java/io/InputStreamReader/getEncoding.java,v
retrieving revision 1.1
diff -u -F^f -r1.1 getEncoding.java
--- gnu/testlet/java/io/InputStreamReader/getEncoding.java 17 Jun 2005
01:49:48 -0000 1.1
+++ gnu/testlet/java/io/InputStreamReader/getEncoding.java 7 Sep 2005
14:06:06 -0000
@@ -165,8 +165,8 @@
} catch (UnsupportedCharsetException uce) {
supported = false;
}
- harness.check(name, extIoNames[i]);
- harness.check(supported, true);
+ if ( supported )
+ harness.check(name, extIoNames[i]);
}
}
next reply other threads:[~2005-09-27 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 8:20 Torben.Nielsen [this message]
2005-09-27 8:53 ` David Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF4E140155.028ECB38-ONC1257089.002DD37D-C1257089.002DD38E@et.ascom.dk \
--to=torben.nielsen@sagemdenmark.dk \
--cc=mauve-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).