XPath test still not commited?

XPath test still not commited?

[Stephane Mikaty]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

The XPath test i submitted on August 16 has still not been committed. As
this was my first submission to this list, It's quite possible I did
something wrong. Can anyone let me know what the status is?

Thanks

-- 
Stephane Mikaty <stephane@mikaty.net>
OpenPGP Key ID: 0x17F0E3F5


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

Re: XPath test still not commited?

[Mark Wielaard]

Hi Stephane,

On Fri, 2006-08-25 at 08:17 +0200, Stephane Mikaty wrote:
> The XPath test i submitted on August 16 has still not been committed. As
> this was my first submission to this list, It's quite possible I did
> something wrong. Can anyone let me know what the status is?

Sorry, I was hoping Chris could take a look. But I forgot he was on
vacation. Chris, if you are back, could you take a look at:
http://sourceware.org/ml/mauve-patches/2006/msg00614.html

Thanks,

Mark

Re: XPath test still not commited?

[Chris Burdess]

Mark Wielaard wrote:
> > The XPath test i submitted on August 16 has still not been committed. As
> > this was my first submission to this list, It's quite possible I did
> > something wrong. Can anyone let me know what the status is?
> 
> Sorry, I was hoping Chris could take a look. But I forgot he was on
> vacation. Chris, if you are back, could you take a look at:
> http://sourceware.org/ml/mauve-patches/2006/msg00614.html

I don't know much about Mauve, but the JAXP part looks correct.
-- 
Chris Burdess

Re: XPath test still not commited?

[Mario Torre]

Il giorno ven, 25/08/2006 alle 13.01 +0100, Chris Burdess ha scritto:
> Mark Wielaard wrote:
> > > The XPath test i submitted on August 16 has still not been committed. As
> > > this was my first submission to this list, It's quite possible I did
> > > something wrong. Can anyone let me know what the status is?
> > 
> > Sorry, I was hoping Chris could take a look. But I forgot he was on
> > vacation. Chris, if you are back, could you take a look at:
> > http://sourceware.org/ml/mauve-patches/2006/msg00614.html
> 
> I don't know much about Mauve, but the JAXP part looks correct.

Hi!

The mauve part is ok (but the test still fails).

Ciao,
Mario
-- 
Lima Software, SO.PR.IND. s.r.l.
http://www.limasoftware.net/
pgp key: http://subkeys.pgp.net/

Please, support open standards:
http://opendocumentfellowship.org/petition/
http://www.nosoftwarepatents.com/

Re: XPath test still not commited?

[Stephane Mikaty]

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

Thanks for the feedback,

So the test is basically OK.
What's the next step to get it committed?

On Fri, 2006-08-25 at 14:23 +0200, Mario Torre wrote:
> Il giorno ven, 25/08/2006 alle 13.01 +0100, Chris Burdess ha scritto:
> > Mark Wielaard wrote:
> > > > The XPath test i submitted on August 16 has still not been committed. As
> > > > this was my first submission to this list, It's quite possible I did
> > > > something wrong. Can anyone let me know what the status is?
> > > 
> > > Sorry, I was hoping Chris could take a look. But I forgot he was on
> > > vacation. Chris, if you are back, could you take a look at:
> > > http://sourceware.org/ml/mauve-patches/2006/msg00614.html
> > 
> > I don't know much about Mauve, but the JAXP part looks correct.
> 
> Hi!
> 
> The mauve part is ok (but the test still fails).
> 
> Ciao,
> Mario
-- 
Stephane Mikaty <stephane@mikaty.net>
OpenPGP Key ID: 0x17F0E3F5


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

FIY: XPath commited

[Mario Torre]

[-- Attachment #1.1: Type: text/plain, Size: 580 bytes --]

Il giorno mar, 29/08/2006 alle 22.55 +0200, Stephane Mikaty ha scritto:
> Thanks for the feedback,
> 
> So the test is basically OK.
> What's the next step to get it committed?

I have committed the attached patch for Stephane:

2006-08-10  Stephane Mikaty  <stephane@mikaty.net>
	
	* gnu/testlet/javax/xml/xpath/XPath.java: New test.

Ciao,
Mario
-- 
Lima Software, SO.PR.IND. s.r.l.
http://www.limasoftware.net/
pgp key: http://subkeys.pgp.net/

Please, support open standards:
http://opendocumentfellowship.org/petition/
http://www.nosoftwarepatents.com/

[-- Attachment #1.2: xpath.patch --]
[-- Type: text/x-patch, Size: 2835 bytes --]

Index: gnu/testlet/javax/xml/xpath/XPath.java
===================================================================
RCS file: gnu/testlet/javax/xml/xpath/XPath.java
diff -N gnu/testlet/javax/xml/xpath/XPath.java
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ gnu/testlet/javax/xml/xpath/XPath.java	1 Jan 1970 00:00:00 -0000
@@ -0,0 +1,70 @@
+// Tags: JDK1.5
+//
+// Copyright (C) 2006 Stephane Mikay <stephane@mikaty.net>
+//
+// This file is part of Mauve.
+//
+// Mauve is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2, or (at your option)
+// any later version.
+//
+// Mauve is distributed in the hope that it will be useful, but
+// WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+// General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Mauve; see the file COPYING.  If not, write to the
+// Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+// 02110-1301 USA.
+
+package gnu.testlet.javax.xml.xpath;
+
+import java.io.StringReader;
+
+import gnu.testlet.TestHarness;
+import gnu.testlet.Testlet;
+
+import javax.xml.namespace.QName;
+import javax.xml.xpath.XPathConstants;
+import javax.xml.xpath.XPathExpressionException;
+import javax.xml.xpath.XPathFactory;
+
+import org.w3c.dom.NodeList;
+import org.xml.sax.InputSource;
+
+/**
+ * JSR 206 (JAXP 1.3) XPath Tests
+ */
+public class XPath implements Testlet {
+
+    public void test( TestHarness harness ) {
+        try {
+            // According to the JAXP 1.3 spec Chapter 13 Section 2.2.4
+            // The XPath 1.0 NodeSet data type Maps to Java org.w3c.dom.NodeList
+            harness.checkPoint( "jaxp-1.3-ch13s2.2.4" );
+            harness.check( nodeset( "//*", "<o/>" ) instanceof NodeList );
+        } catch ( XPathExpressionException e ) {
+            harness.debug( e );
+            harness.check( false );
+        }
+    }
+
+    private Object nodeset( String expr, String document )
+            throws XPathExpressionException {
+        return eval( expr, document, XPathConstants.NODESET );
+    }
+
+    private Object eval( String expr, String document, QName returnType )
+            throws XPathExpressionException {
+        final XPathFactory factory = XPathFactory.newInstance();
+        final javax.xml.xpath.XPath xpath = factory.newXPath();
+        return xpath.evaluate( expr, source( document ), returnType );
+    }
+
+    private InputSource source( String xml ) {
+        return new InputSource( new StringReader( xml ) );
+    }
+
+}

[-- Attachment #2: Questa è una parte del messaggio firmata digitalmente --]
[-- Type: application/pgp-signature, Size: 189 bytes --]