mauve build fix for VisualTestlet

mauve build fix for VisualTestlet

[Paul Jenner]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

Hi.

"make" step was failing for me with clean checkout of mauve without the
attached patch.

Could someone please review and apply?

For reference, ecj gave error:

home/psj/software/install/bin/ecj
-bootclasspath /home/psj/software/install/classpath-cvs/share/classpath/glibj.zip Harness.java RunnerProcess.java gnu/testlet/config.java gnu/testlet/TestHarness.java gnu/testlet/Testlet.java gnu/testlet/TestSecurityManager.java gnu/testlet/ResourceNotFoundException.java gnu/testlet/TestReport.java gnu/testlet/TestResult.java
----------
1. ERROR in RunnerProcess.java
 (at line 32)
        import gnu.testlet.VisualTestlet;
               ^^^^^^^^^^^^^^^^^^^^^^^^^
The import gnu.testlet.VisualTestlet cannot be resolved
----------
2. ERROR in RunnerProcess.java
 (at line 279)
        if (o instanceof VisualTestlet)
                         ^^^^^^^^^^^^^
VisualTestlet cannot be resolved to a type
----------
2 problems (2 errors)make: *** [harness] Error 255

Thanks,

Paul

-- 
Paul Jenner <psj@harker.dyndns.org>

[-- Attachment #2: mauve-VisualTestletbuildfix.patch --]
[-- Type: text/x-patch, Size: 748 bytes --]

Common subdirectories: mauve/CVS and mauve.psj/CVS
Common subdirectories: mauve/.externalToolBuilders and mauve.psj/.externalToolBuilders
Common subdirectories: mauve/gnu and mauve.psj/gnu
Common subdirectories: mauve/junit and mauve.psj/junit
diff -u mauve/Makefile.am mauve.psj/Makefile.am
--- mauve/Makefile.am	2006-06-28 06:00:31.000000000 +0100
+++ mauve.psj/Makefile.am	2006-10-30 19:42:32.000000000 +0000
@@ -18,7 +18,8 @@
 	gnu/testlet/TestSecurityManager.java \
 	gnu/testlet/ResourceNotFoundException.java \
 	gnu/testlet/TestReport.java \
-	gnu/testlet/TestResult.java
+	gnu/testlet/TestResult.java \
+	gnu/testlet/VisualTestlet.java
 
 harness:
 	$(JAVAC) $(harness_files)
Common subdirectories: mauve/.settings and mauve.psj/.settings

Re: mauve build fix for VisualTestlet

[Paul Jenner]

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

Hi list.

Was it just me that needed this patch to build mauve from clean
checkout?

The build machinery looks broken to me without this patch but I may be
missing something.

Thanks,

Paul

On Mon, 2006-10-30 at 19:48 +0000, Paul Jenner wrote:
> Hi.
> 
> "make" step was failing for me with clean checkout of mauve without the
> attached patch.
> 
> Could someone please review and apply?
> 
> For reference, ecj gave error:
> 
> home/psj/software/install/bin/ecj
> -bootclasspath /home/psj/software/install/classpath-cvs/share/classpath/glibj.zip Harness.java RunnerProcess.java gnu/testlet/config.java gnu/testlet/TestHarness.java gnu/testlet/Testlet.java gnu/testlet/TestSecurityManager.java gnu/testlet/ResourceNotFoundException.java gnu/testlet/TestReport.java gnu/testlet/TestResult.java
> ----------
> 1. ERROR in RunnerProcess.java
>  (at line 32)
>         import gnu.testlet.VisualTestlet;
>                ^^^^^^^^^^^^^^^^^^^^^^^^^
> The import gnu.testlet.VisualTestlet cannot be resolved
> ----------
> 2. ERROR in RunnerProcess.java
>  (at line 279)
>         if (o instanceof VisualTestlet)
>                          ^^^^^^^^^^^^^
> VisualTestlet cannot be resolved to a type
> ----------
> 2 problems (2 errors)make: *** [harness] Error 255
> 
> Thanks,
> 
> Paul
> 
-- 
Paul Jenner <psj@harker.dyndns.org>

[-- Attachment #2: mauve-VisualTestletbuildfix.patch --]
[-- Type: text/x-patch, Size: 748 bytes --]

Common subdirectories: mauve/CVS and mauve.psj/CVS
Common subdirectories: mauve/.externalToolBuilders and mauve.psj/.externalToolBuilders
Common subdirectories: mauve/gnu and mauve.psj/gnu
Common subdirectories: mauve/junit and mauve.psj/junit
diff -u mauve/Makefile.am mauve.psj/Makefile.am
--- mauve/Makefile.am	2006-06-28 06:00:31.000000000 +0100
+++ mauve.psj/Makefile.am	2006-10-30 19:42:32.000000000 +0000
@@ -18,7 +18,8 @@
 	gnu/testlet/TestSecurityManager.java \
 	gnu/testlet/ResourceNotFoundException.java \
 	gnu/testlet/TestReport.java \
-	gnu/testlet/TestResult.java
+	gnu/testlet/TestResult.java \
+	gnu/testlet/VisualTestlet.java
 
 harness:
 	$(JAVAC) $(harness_files)
Common subdirectories: mauve/.settings and mauve.psj/.settings

Re: mauve build fix for VisualTestlet

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Hi Paul,

On Sat, 2006-11-25 at 15:28 +0000, Paul Jenner wrote:
> Was it just me that needed this patch to build mauve from clean
> checkout?
> 
> The build machinery looks broken to me without this patch but I may be
> missing something.

Weird that nobody else hit this. I just hit it on my local machine, but
builder seems fine without this patch. But since that doesn't make sense
at all I am just checking it in:

2006-11-26  Paul Jenner  <psj@harker.dyndns.org>

        * Makefile.am (harness_files): Add VisualTestlet.java.
        * Makefile.in: Regenerated.

Thanks,

Mark

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: mauve build fix for VisualTestlet

[Roman Kennke]

Hi there,

> On Sat, 2006-11-25 at 15:28 +0000, Paul Jenner wrote:
> > Was it just me that needed this patch to build mauve from clean
> > checkout?
> > 
> > The build machinery looks broken to me without this patch but I may be
> > missing something.
> 
> Weird that nobody else hit this.

That's probably because Eclipse deals OK with this. Sorry for the
problems...

/Roman