FYI: New ComponentEvent test

FYI: New ComponentEvent test

[Tania Bento]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

Hey,

This adds a new test for java.awt.event.ComponentEvent.paramString().

Cheers,
Tania

2006-11-03  Tania Bento  <tbento@redhat.com>

        * gnu/testlet/java/awt/event/ComponentEvent/paramString.java:
New test.




[-- Attachment #2: patch.diff --]
[-- Type: text/x-patch, Size: 2282 bytes --]

Index: gnu/testlet/java/awt/event/ComponentEvent/paramString.java
===================================================================
RCS file: gnu/testlet/java/awt/event/ComponentEvent/paramString.java
diff -N gnu/testlet/java/awt/event/ComponentEvent/paramString.java
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ gnu/testlet/java/awt/event/ComponentEvent/paramString.java	3 Nov 2006 14:58:55 -0000
@@ -0,0 +1,55 @@
+/* paramString.java 
+   Copyright (C) 2006 RedHat
+   
+This file is part of Mauve.
+
+Mauve is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+
+Mauve is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with Mauve; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+02110-1301 USA.
+
+*/
+
+// Tags: 1.4
+
+package gnu.testlet.java.awt.event.ComponentEvent;
+
+import java.awt.Button;
+import java.awt.event.ComponentEvent;
+
+import gnu.testlet.TestHarness;
+import gnu.testlet.Testlet;
+
+public class paramString implements Testlet
+{
+
+  public void test(TestHarness harness)
+  {
+    Button button = new Button();
+    ComponentEvent event = new ComponentEvent(button, 
+                                              ComponentEvent.COMPONENT_MOVED);
+
+    // Check that previous code produced incorrect string representation.
+    harness.check(! event.paramString().equalsIgnoreCase(
+              "COMPONENT_MOVED java.awt.Rectangle[x=0,y=0,width=0,height=0]"));
+    
+    // Check that current code produces correct string representation.
+    harness.check(event.paramString(), "COMPONENT_MOVED (0,0 0x0)");
+    
+    // Check that correct string representation is returned when
+    // an invalid event ID is given.
+    event = new ComponentEvent(button, ComponentEvent.COMPONENT_MOVED + 1024);
+    harness.check(event.paramString(), "unknown type");
+  }
+
+}

Re: FYI: New ComponentEvent test

[David Gilbert]

Tania Bento wrote:
> Hey,
>
> This adds a new test for java.awt.event.ComponentEvent.paramString().
>
> Cheers,
> Tania
>
> 2006-11-03  Tania Bento  <tbento@redhat.com>
>
>         * gnu/testlet/java/awt/event/ComponentEvent/paramString.java:
> New test.
>
>
>
>   
> ------------------------------------------------------------------------
>
> Index: gnu/testlet/java/awt/event/ComponentEvent/paramString.java
> ===================================================================
> RCS file: gnu/testlet/java/awt/event/ComponentEvent/paramString.java
> diff -N gnu/testlet/java/awt/event/ComponentEvent/paramString.java
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ gnu/testlet/java/awt/event/ComponentEvent/paramString.java	3 Nov 2006 14:58:55 -0000
> @@ -0,0 +1,55 @@
> +/* paramString.java 
> +   Copyright (C) 2006 RedHat
> +   
> +This file is part of Mauve.
> +
> +Mauve is free software; you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation; either version 2, or (at your option)
> +any later version.
> +
> +Mauve is distributed in the hope that it will be useful, but
> +WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with Mauve; see the file COPYING.  If not, write to the
> +Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> +02110-1301 USA.
> +
> +*/
> +
> +// Tags: 1.4
>   

My mind has gone blank on this but I thought I'd flag it anyway...does 
the tag need to be 'JDK1.4', or does '1.4' work as well?

Regards,

Dave

Re: FYI: New ComponentEvent test

[Roman Kennke]

Hi David, hi Tania,

> > This adds a new test for java.awt.event.ComponentEvent.paramString().
> >
> > Cheers,
> > Tania
> >
> > 2006-11-03  Tania Bento  <tbento@redhat.com>
> >
> >         * gnu/testlet/java/awt/event/ComponentEvent/paramString.java:
> > New test.


> > +
> > +// Tags: 1.4
> >   
> 
> My mind has gone blank on this but I thought I'd flag it anyway...does 
> the tag need to be 'JDK1.4', or does '1.4' work as well?

I think it should be JDKx.y. But the real question probably is, if that
shouldn't really be JDK1.1? After all, this class and method have been
present since JDK1.1.

/Roman

Re: FYI: New ComponentEvent test

[Tania Bento]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

Hey,

On Fri, 2006-11-03 at 16:10 +0100, Roman Kennke wrote:
> Hi David, hi Tania,
> 
> > > This adds a new test for java.awt.event.ComponentEvent.paramString().
> > >
> > > Cheers,
> > > Tania
> > >
> > > 2006-11-03  Tania Bento  <tbento@redhat.com>
> > >
> > >         * gnu/testlet/java/awt/event/ComponentEvent/paramString.java:
> > > New test.
> 
> 
> > > +
> > > +// Tags: 1.4
> > >   
> > 
> > My mind has gone blank on this but I thought I'd flag it anyway...does 
> > the tag need to be 'JDK1.4', or does '1.4' work as well?
> 
> I think it should be JDKx.y. But the real question probably is, if that
> shouldn't really be JDK1.1? After all, this class and method have been
> present since JDK1.1.
> 
> /Roman

Sorry about that.  I've changed the tag and committed the file again.

Thanks,
Tania

2006-11-03  Tania Bento  <tbento@redhat.com>

        * gnu/testlet/java/awt/event/ComponentEvent/paramString.java:
Changed
        tag documentation to JDK1.1.


[-- Attachment #2: patch.diff --]
[-- Type: text/x-patch, Size: 572 bytes --]

Index: gnu/testlet/java/awt/event/ComponentEvent/paramString.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/awt/event/ComponentEvent/paramString.java,v
retrieving revision 1.1
diff -u -r1.1 paramString.java
--- gnu/testlet/java/awt/event/ComponentEvent/paramString.java	3 Nov 2006 15:01:40 -0000	1.1
+++ gnu/testlet/java/awt/event/ComponentEvent/paramString.java	3 Nov 2006 15:18:03 -0000
@@ -20,7 +20,7 @@
 
 */
 
-// Tags: 1.4
+// Tags: JDK1.1
 
 package gnu.testlet.java.awt.event.ComponentEvent;