public inbox for mauve-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Omair Majid <omajid@redhat.com>
Cc: mauve-patches@sources.redhat.com
Subject: Re: [PATCH] Fix xmlout option
Date: Fri, 13 Feb 2009 15:52:00 -0000	[thread overview]
Message-ID: <1234540345.2290.45.camel@fedora.wildebeest.org> (raw)
In-Reply-To: <49958CC9.1090208@redhat.com>

Hi Omair,

On Fri, 2009-02-13 at 10:07 -0500, Omair Majid wrote:
> Good catch. Fixed patch attached. I am not sure how the help message 
> indicates that the file name is optional. 'filename' in '-file 
> [filename]' is required and so is 'millis' in '-timeout [millis]'.

O right, hmmm, how unconventional. But ok, lets keep them all the same.
Applied your patch as:

2009-02-13  Omair Majid  <omajid@redhat.com>

        * Harness.java (setupHarness): Check for -xmlout file argument.

Thanks,

Mark

      reply	other threads:[~2009-02-13 15:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 16:54 Omair Majid
2009-02-13 13:02 ` Mark Wielaard
2009-02-13 15:08   ` Omair Majid
2009-02-13 15:52     ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234540345.2290.45.camel@fedora.wildebeest.org \
    --to=mark@klomp.org \
    --cc=mauve-patches@sources.redhat.com \
    --cc=omajid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).