public inbox for mauve-patches@sourceware.org
 help / color / mirror / Atom feed
From: Omair Majid <omajid@redhat.com>
To: mauve-patches@sources.redhat.com
Subject: [PATCH] Fix xmlout option
Date: Thu, 12 Feb 2009 16:54:00 -0000	[thread overview]
Message-ID: <49945396.5050000@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

Hi,

The attached patch fixes the issue in mauve when running the entire test 
suite with -xmlout fails:

$ java Harness -vm /usr/bin/java -xmlout xmloutputfile
No tests were run.  Possible reasons may be listed below.
Did you specify a test that doesn't exist or a folder that contains no 
tests?

The bug seems to be that mauve ignores the -xmlout option and then 
treats xmloutputfile as the name of the test to run. The patch adds a 
case in Harness.setupHarness() so that the argument after -xmlout is 
skipped (it is later checked in RunnerProcess).

Cheers,
Omair

[-- Attachment #2: harness-option-xmlout.patch --]
[-- Type: text/plain, Size: 603 bytes --]

--- Harness.java.orig	2009-02-12 11:30:11.000000000 -0500
+++ Harness.java	2009-02-12 11:34:23.000000000 -0500
@@ -338,6 +338,13 @@
                     "after '-timeout'.  Exit");
             runner_timeout = Long.parseLong(args[i]);
           }
+        else if (args[i].equals("-xmlout"))
+          {
+            // Option handled by RunnerProcess
+            // Next arg is filename; RunnerProcess checks the args
+            // again
+            ++i;
+          }
         else if (args[i].charAt(0) == '-')
           {
             // One of the ignored options (handled by RunnerProcess)

             reply	other threads:[~2009-02-12 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 16:54 Omair Majid [this message]
2009-02-13 13:02 ` Mark Wielaard
2009-02-13 15:08   ` Omair Majid
2009-02-13 15:52     ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49945396.5050000@redhat.com \
    --to=omajid@redhat.com \
    --cc=mauve-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).