public inbox for mauve-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joshua Sumali <jsumali@redhat.com>
To: mauve-patches@sources.redhat.com
Subject: FYI: Test Fix
Date: Fri, 13 Jul 2007 20:22:00 -0000	[thread overview]
Message-ID: <4697DEF9.4000409@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

This patch fixed a couple of tests in gnu/testlet/java/text/SimpleDateFormat

It just needed a simple time zone change to match the locale. Now passes 
on openJDK.

2007-07-13    Joshua Sumali    <jsumali@redhat.com>

    * gnu/testlet/java/text/SimpleDateFormat/getDateFormatSymbols.java
    (test): Fixed incorrect test.
    * gnu/testlet/java/text/SimpleDateFormat/setDateFormatSymbols.java
    (test): Fixed incorrect test.

[-- Attachment #2: getDateFormatSymbols.patch.diff --]
[-- Type: text/x-patch, Size: 1107 bytes --]


#P mauve
Index: gnu/testlet/java/text/SimpleDateFormat/getDateFormatSymbols.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/text/SimpleDateFormat/getDateFormatSymbols.java,v
retrieving revision 1.1
diff -u -r1.1 getDateFormatSymbols.java
--- gnu/testlet/java/text/SimpleDateFormat/getDateFormatSymbols.java	11 Nov 2004 09:37:20 -0000	1.1
+++ gnu/testlet/java/text/SimpleDateFormat/getDateFormatSymbols.java	13 Jul 2007 20:16:01 -0000
@@ -28,6 +28,7 @@
 import java.text.SimpleDateFormat;
 import java.util.Date;
 import java.util.Locale;
+import java.util.TimeZone;
 
 /**
  * Some checks for the getDateFormatSymbols() method in the SimpleDateFormat
@@ -47,6 +48,7 @@
     // symbols, so updating them should not affect the results of the
     // date formatter...
     SimpleDateFormat sdf = new SimpleDateFormat("E", Locale.UK);
+    sdf.setTimeZone(TimeZone.getTimeZone("UTC"));
     Date jan1_2005 = new Date(1104537600000L);
     harness.check(sdf.format(jan1_2005), "Sat");
     DateFormatSymbols s = sdf.getDateFormatSymbols();


[-- Attachment #3: setDateFormatSymbols.patch.diff --]
[-- Type: text/x-patch, Size: 1075 bytes --]


#P mauve
Index: gnu/testlet/java/text/SimpleDateFormat/setDateFormatSymbols.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/text/SimpleDateFormat/setDateFormatSymbols.java,v
retrieving revision 1.1
diff -u -r1.1 setDateFormatSymbols.java
--- gnu/testlet/java/text/SimpleDateFormat/setDateFormatSymbols.java	11 Nov 2004 09:37:20 -0000	1.1
+++ gnu/testlet/java/text/SimpleDateFormat/setDateFormatSymbols.java	13 Jul 2007 20:14:26 -0000
@@ -28,6 +28,7 @@
 import java.text.SimpleDateFormat;
 import java.util.Date;
 import java.util.Locale;
+import java.util.TimeZone;
 
 /**
  * Some checks for the setDateFormatSymbols() method in the SimpleDateFormat
@@ -45,6 +46,7 @@
   {
     // check that changing the short weekdays does work...
     SimpleDateFormat sdf = new SimpleDateFormat("E", Locale.UK);
+    sdf.setTimeZone(TimeZone.getTimeZone("UTC"));
     Date jan1_2005 = new Date(1104537600000L);
     harness.check(sdf.format(jan1_2005), "Sat");
     DateFormatSymbols s = sdf.getDateFormatSymbols();


             reply	other threads:[~2007-07-13 20:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-13 20:22 Joshua Sumali [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-07-24 19:37 Joshua Sumali
2007-07-24 13:28 Joshua Sumali
2007-07-24 20:17 ` David Daney
2007-07-18 18:49 Joshua Sumali
2007-07-13 16:04 Joshua Sumali
2007-07-10 14:03 Joshua Sumali
2007-06-29 19:38 Tania Bento
2007-06-29 22:42 ` Mario Torre
2007-07-03 13:11   ` Tania Bento

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4697DEF9.4000409@redhat.com \
    --to=jsumali@redhat.com \
    --cc=mauve-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).