public inbox for mauve-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joshua Sumali <jsumali@redhat.com>
To: mauve-patches@sources.redhat.com
Subject: FYI: Test Fix
Date: Tue, 10 Jul 2007 14:03:00 -0000	[thread overview]
Message-ID: <469391BC.8030401@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

This patch fixed an incorrect test in 
gnu/testlet/java/beans/Expression/check.java

A test in Expression was looking for a return value for the Array.set 
method, but
should not be since the method is public static void. Test now passes 
for java 1.4.2
and 1.5.

2007-07-10    Joshua Sumali    <jsumali@redhat.com>

    * gnu/testlet/java/beans/Expression/check.java:
    (test):    Fixed incorrect test.



[-- Attachment #2: patch.diff --]
[-- Type: text/x-patch, Size: 859 bytes --]

### Eclipse Workspace Patch 1.0
#P mauve
Index: gnu/testlet/java/beans/Expression/check.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/beans/Expression/check.java,v
retrieving revision 1.2
diff -u -r1.2 check.java
--- gnu/testlet/java/beans/Expression/check.java	4 Jul 2004 15:58:18 -0000	1.2
+++ gnu/testlet/java/beans/Expression/check.java	10 Jul 2007 13:49:52 -0000
@@ -145,9 +145,9 @@
       {
 	harness.fail("Expression set failed");
       }
-    harness.check(res4 instanceof Integer);
-    harness.check(((Integer)res4).intValue() == 3,
-		  "Test Expression of array and method named set");
+    //Array.set is public static void and should have no return value
+    harness.check(res4 == null);
+
     harness.check(iarray[2] == 6);
 
     Object arg5[] = { new Integer(2) };




             reply	other threads:[~2007-07-10 14:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-10 14:03 Joshua Sumali [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-07-24 19:37 Joshua Sumali
2007-07-24 13:28 Joshua Sumali
2007-07-24 20:17 ` David Daney
2007-07-18 18:49 Joshua Sumali
2007-07-13 20:22 Joshua Sumali
2007-07-13 16:04 Joshua Sumali
2007-06-29 19:38 Tania Bento
2007-06-29 22:42 ` Mario Torre
2007-07-03 13:11   ` Tania Bento

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469391BC.8030401@redhat.com \
    --to=jsumali@redhat.com \
    --cc=mauve-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).