public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Fix AArch32 semihosting SYS_EXIT call on semihosting v1.
@ 2018-07-11 15:18 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2018-07-11 15:18 UTC (permalink / raw)
To: newlib-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=430b52911102a2ee48f1857954f2aeacc5b56dc6
commit 430b52911102a2ee48f1857954f2aeacc5b56dc6
Author: Tamar Christina <tamar.christina@arm.com>
Date: Wed Jul 11 13:26:16 2018 +0100
Fix AArch32 semihosting SYS_EXIT call on semihosting v1.
The current SYS_EXIT has a bug that when making the call it always uses
the v2 calling convention. This is undefined behavior according to the
semihosting specification:
https://developer.arm.com/docs/100863/latest/semihosting-operations/sys_exit-0x18
This patch fixes it by making sure v1 passes the argument directly in the register instead
of in a block. And for v2 it does the same if the v2 extension isn't supported.
The sequence generated now is
12424: ebfffecd bl 11f60 <_has_ext_exit_extended>
12428: e3500000 cmp r0, #0
1242c: 11a0500d movne r5, sp
12430: 059d5000 ldreq r5, [sp]
12434: e1a00004 mov r0, r4
12438: e1a01005 mov r1, r5
1243c: ef00f000 svc 0x0000f000
Signed-off-by: Tamar Christina <tamar.christina@arm.com>
Diff:
---
libgloss/arm/_kill.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/libgloss/arm/_kill.c b/libgloss/arm/_kill.c
index fc77e80..278ded7 100644
--- a/libgloss/arm/_kill.c
+++ b/libgloss/arm/_kill.c
@@ -39,7 +39,13 @@ _kill (int pid, int sig)
}
}
+#if SEMIHOST_V2
+if (_has_ext_exit_extended ())
return do_AngelSWI (insn, block);
+else
+#endif
+ return do_AngelSWI (insn, (void*)block[0]);
+
#else
asm ("swi %a0" :: "i" (SWI_Exit));
#endif
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-07-11 15:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11 15:18 [newlib-cygwin] Fix AArch32 semihosting SYS_EXIT call on semihosting v1 Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).