public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] newlib: wordexp: drop dangerous fprintf
Date: Wed, 08 Aug 2018 08:52:00 -0000	[thread overview]
Message-ID: <20180808085255.78394.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=5ace9004d9b982ba8887df41139295792c130020

commit 5ace9004d9b982ba8887df41139295792c130020
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Wed Aug 8 10:39:45 2018 +0200

    newlib: wordexp: drop dangerous fprintf
    
    wordexp uses fprintf in a dangerous way.  It uses an unchecked
    input string as format string, rather than as parameter to a %s.
    Replace fprintf with fputs.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 newlib/libc/posix/wordexp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/newlib/libc/posix/wordexp.c b/newlib/libc/posix/wordexp.c
index 3e90c3a..dcda3d2 100644
--- a/newlib/libc/posix/wordexp.c
+++ b/newlib/libc/posix/wordexp.c
@@ -127,9 +127,9 @@ wordexp(const char *__restrict words, wordexp_t *__restrict pwordexp, int flags)
 
           if (flags & WRDE_SHOWERR)
             {
-              fprintf(stderr, tmp);
+              fputs(tmp, stderr);
               while(fgets(tmp, MAXLINELEN, f_err))
-                fprintf(stderr, tmp);
+                fputs(tmp, stderr);
             }
 
           goto cleanup;


                 reply	other threads:[~2018-08-08  8:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180808085255.78394.qmail@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).