public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] newlib: wordexp: drop dangerous fprintf
@ 2018-08-08  8:52 Corinna Vinschen
  0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2018-08-08  8:52 UTC (permalink / raw)
  To: newlib-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=5ace9004d9b982ba8887df41139295792c130020

commit 5ace9004d9b982ba8887df41139295792c130020
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Wed Aug 8 10:39:45 2018 +0200

    newlib: wordexp: drop dangerous fprintf
    
    wordexp uses fprintf in a dangerous way.  It uses an unchecked
    input string as format string, rather than as parameter to a %s.
    Replace fprintf with fputs.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 newlib/libc/posix/wordexp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/newlib/libc/posix/wordexp.c b/newlib/libc/posix/wordexp.c
index 3e90c3a..dcda3d2 100644
--- a/newlib/libc/posix/wordexp.c
+++ b/newlib/libc/posix/wordexp.c
@@ -127,9 +127,9 @@ wordexp(const char *__restrict words, wordexp_t *__restrict pwordexp, int flags)
 
           if (flags & WRDE_SHOWERR)
             {
-              fprintf(stderr, tmp);
+              fputs(tmp, stderr);
               while(fgets(tmp, MAXLINELEN, f_err))
-                fprintf(stderr, tmp);
+                fputs(tmp, stderr);
             }
 
           goto cleanup;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-08-08  8:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-08  8:52 [newlib-cygwin] newlib: wordexp: drop dangerous fprintf Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).