public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Fix vfwscanf(3) assignment suppression flag handling bug
@ 2019-06-03 8:40 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2019-06-03 8:40 UTC (permalink / raw)
To: newlib-cvs
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 1440 bytes --]
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=d5daede26c651f4e9d6c7abbd2dd2937a1e24e2d
commit d5daede26c651f4e9d6c7abbd2dd2937a1e24e2d
Author: Lucio Andrés Illanes Albornoz <lucio@lucioillanes.de>
Date: Sat Jun 1 10:33:19 2019 +0200
Fix vfwscanf(3) assignment suppression flag handling bug
newlib's vfwscanf(3) (or specifically, __SVFWSCANF_R()) fails to correctly set
the assignment-suppressing character (`*') flag[1] which, when present in the
formatting string, results in undefined behaviour comprising retrieving and
dereferencing a pointer that was not supplied by the caller as such or at all.
When compared to the vfscanf(3) implementation, this would appear to be over
the missing goto match_failure statement preceded by the flags test seen below.
Hence, this patch (re)introduces it.
[1] <http://pubs.opengroup.org/onlinepubs/009695399/functions/fwscanf.html>
--
Diff:
---
newlib/libc/stdio/vfwscanf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/newlib/libc/stdio/vfwscanf.c b/newlib/libc/stdio/vfwscanf.c
index 0464b08..ffb6cc8 100644
--- a/newlib/libc/stdio/vfwscanf.c
+++ b/newlib/libc/stdio/vfwscanf.c
@@ -602,6 +602,7 @@ __SVFWSCANF_R (struct _reent *rptr,
case L'*':
if ((flags & (CHAR | SHORT | LONG | LONGDBL | SUPPRESS | MALLOC))
|| width)
+ goto match_failure;
flags |= SUPPRESS;
goto again;
case L'l':
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-06-03 8:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-03 8:40 [newlib-cygwin] Fix vfwscanf(3) assignment suppression flag handling bug Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).