public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Fix __getreent stack calculations for AMD GCN
@ 2019-06-07 17:59 Jeff Johnston
0 siblings, 0 replies; only message in thread
From: Jeff Johnston @ 2019-06-07 17:59 UTC (permalink / raw)
To: newlib-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=eb429ad509bf30a27a40b7a9b68d65915e18fb4f
commit eb429ad509bf30a27a40b7a9b68d65915e18fb4f
Author: Jeff Johnston <jjohnstn@redhat.com>
Date: Fri Jun 7 13:57:45 2019 -0400
Fix __getreent stack calculations for AMD GCN
From: Andrew Stubbs <ams@codesourcery.com>
Fix a bug in which the high-part of 64-bit values are being corrupted, leading
to erroneous stack overflow errors. The problem was only that the mixed-size
calculations are being treated as signed when they should be unsigned.
Diff:
---
newlib/libc/machine/amdgcn/getreent.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/newlib/libc/machine/amdgcn/getreent.c b/newlib/libc/machine/amdgcn/getreent.c
index 5a28aa4..bc50ca0 100644
--- a/newlib/libc/machine/amdgcn/getreent.c
+++ b/newlib/libc/machine/amdgcn/getreent.c
@@ -35,9 +35,9 @@ __getreent (void)
s[4:5] contains the dispatch pointer.
WARNING: this code will break if s[0:3] is ever used for anything! */
- const register long buffer_descriptor asm("s0");
- long private_segment = buffer_descriptor & 0x0000ffffffffffff;
- const register int stack_offset asm("s11");
+ const register unsigned long buffer_descriptor asm("s0");
+ unsigned long private_segment = buffer_descriptor & 0x0000ffffffffffff;
+ const register unsigned int stack_offset asm("s11");
const register hsa_kernel_dispatch_packet_t *dispatch_ptr asm("s4");
struct data {
@@ -45,9 +45,9 @@ __getreent (void)
struct _reent reent;
} *data;
- long stack_base = private_segment + stack_offset;
- long stack_end = stack_base + dispatch_ptr->private_segment_size * 64;
- long addr = (stack_end - sizeof(struct data)) & ~7;
+ unsigned long stack_base = private_segment + stack_offset;
+ unsigned long stack_end = stack_base + dispatch_ptr->private_segment_size * 64;
+ unsigned long addr = (stack_end - sizeof(struct data)) & ~7;
data = (struct data *)addr;
register long sp asm("s16");
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-06-07 17:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-07 17:59 [newlib-cygwin] Fix __getreent stack calculations for AMD GCN Jeff Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).