public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] riscv: fix integer wraparound in memcpy
@ 2020-07-27  8:14 Corinna Vinschen
  0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2020-07-27  8:14 UTC (permalink / raw)
  To: newlib-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=123b8065237a3fb644528d3e95216ade336334bd

commit 123b8065237a3fb644528d3e95216ade336334bd
Author: PkmX via Newlib <newlib@sourceware.org>
Date:   Fri Jul 24 19:07:45 2020 +0800

    riscv: fix integer wraparound in memcpy
    
    This patch fixes a bug in RISC-V's memcpy implementation where an
    integer wraparound occurs when src + size < 8 * sizeof(long), causing
    the word-sized copy loop to be incorrectly entered.
    
    Signed-off-by: Chih-Mao Chen <cmchen@andestech.com>

Diff:
---
 newlib/libc/machine/riscv/memcpy.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/newlib/libc/machine/riscv/memcpy.c b/newlib/libc/machine/riscv/memcpy.c
index 07e8e0076..4098f3ab1 100644
--- a/newlib/libc/machine/riscv/memcpy.c
+++ b/newlib/libc/machine/riscv/memcpy.c
@@ -51,9 +51,9 @@ small:
   const long *lb = (const long *)b;
   long *lend = (long *)((uintptr_t)end & ~msk);
 
-  if (unlikely (la < (lend - 8)))
+  if (unlikely (lend - la > 8))
     {
-      while (la < (lend - 8))
+      while (lend - la > 8)
 	{
 	  long b0 = *lb++;
 	  long b1 = *lb++;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-07-27  8:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27  8:14 [newlib-cygwin] riscv: fix integer wraparound in memcpy Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).