public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jeff Johnston <jjohnstn@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] libc/include/math.h: Remove parameter name
Date: Sat, 26 Sep 2020 02:54:05 +0000 (GMT)	[thread overview]
Message-ID: <20200926025405.7EFD23952C1C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=4c49accf8997da21be19be0396b2a88f33b9f949

commit 4c49accf8997da21be19be0396b2a88f33b9f949
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date:   Mon Sep 21 15:22:30 2020 +0000

    libc/include/math.h: Remove parameter name
    
    As discussed in GCC bug 97088
    (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
    prototypes of library functions should use reserved names, or no name
    at all.
    
    This patch removes the 'x' parameter name from
    extern int __isinff (float);
    extern int __isinfd (double);
    extern int __isnanf (float);
    extern int __isnand (double);
    extern int __fpclassifyf (float);
    extern int __fpclassifyd (double);
    extern int __signbitf (float);
    extern int __signbitd (double);
    
    to avoid possible clashes with user code in case someone uses
    before including Newlib's math.h (or uses some other conflicting
    definition)

Diff:
---
 newlib/libc/include/math.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h
index 5e6155cc4..ba1a8a17e 100644
--- a/newlib/libc/include/math.h
+++ b/newlib/libc/include/math.h
@@ -201,14 +201,14 @@ extern int isnan (double);
 # define math_errhandling (_MATH_ERRHANDLING_ERRNO | _MATH_ERRHANDLING_ERREXCEPT)
 #endif
 
-extern int __isinff (float x);
-extern int __isinfd (double x);
-extern int __isnanf (float x);
-extern int __isnand (double x);
-extern int __fpclassifyf (float x);
-extern int __fpclassifyd (double x);
-extern int __signbitf (float x);
-extern int __signbitd (double x);
+extern int __isinff (float);
+extern int __isinfd (double);
+extern int __isnanf (float);
+extern int __isnand (double);
+extern int __fpclassifyf (float);
+extern int __fpclassifyd (double);
+extern int __signbitf (float);
+extern int __signbitd (double);
 
 /* Note: isinf and isnan were once functions in newlib that took double
  *       arguments.  C99 specifies that these names are reserved for macros


                 reply	other threads:[~2020-09-26  2:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200926025405.7EFD23952C1C@sourceware.org \
    --to=jjohnstn@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).