public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] libc/include/math.h: Remove parameter name
@ 2020-09-26  2:54 Jeff Johnston
  0 siblings, 0 replies; only message in thread
From: Jeff Johnston @ 2020-09-26  2:54 UTC (permalink / raw)
  To: newlib-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=4c49accf8997da21be19be0396b2a88f33b9f949

commit 4c49accf8997da21be19be0396b2a88f33b9f949
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date:   Mon Sep 21 15:22:30 2020 +0000

    libc/include/math.h: Remove parameter name
    
    As discussed in GCC bug 97088
    (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
    prototypes of library functions should use reserved names, or no name
    at all.
    
    This patch removes the 'x' parameter name from
    extern int __isinff (float);
    extern int __isinfd (double);
    extern int __isnanf (float);
    extern int __isnand (double);
    extern int __fpclassifyf (float);
    extern int __fpclassifyd (double);
    extern int __signbitf (float);
    extern int __signbitd (double);
    
    to avoid possible clashes with user code in case someone uses
    before including Newlib's math.h (or uses some other conflicting
    definition)

Diff:
---
 newlib/libc/include/math.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h
index 5e6155cc4..ba1a8a17e 100644
--- a/newlib/libc/include/math.h
+++ b/newlib/libc/include/math.h
@@ -201,14 +201,14 @@ extern int isnan (double);
 # define math_errhandling (_MATH_ERRHANDLING_ERRNO | _MATH_ERRHANDLING_ERREXCEPT)
 #endif
 
-extern int __isinff (float x);
-extern int __isinfd (double x);
-extern int __isnanf (float x);
-extern int __isnand (double x);
-extern int __fpclassifyf (float x);
-extern int __fpclassifyd (double x);
-extern int __signbitf (float x);
-extern int __signbitd (double x);
+extern int __isinff (float);
+extern int __isinfd (double);
+extern int __isnanf (float);
+extern int __isnand (double);
+extern int __fpclassifyf (float);
+extern int __fpclassifyd (double);
+extern int __signbitf (float);
+extern int __signbitd (double);
 
 /* Note: isinf and isnan were once functions in newlib that took double
  *       arguments.  C99 specifies that these names are reserved for macros


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-09-26  2:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-26  2:54 [newlib-cygwin] libc/include/math.h: Remove parameter name Jeff Johnston

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).