public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin/main] Revert "* libc/stdlib/mbtowc_r.c (__ascii_mbtowc): Disallow conversion of"
@ 2023-07-31 20:52 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2023-07-31 20:52 UTC (permalink / raw)
To: newlib-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=8a4318943875cd922601d34e54ce8a83ad2e733c
commit 8a4318943875cd922601d34e54ce8a83ad2e733c
Author: Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Mon Jul 31 12:44:16 2023 +0200
Commit: Corinna Vinschen <corinna@vinschen.de>
CommitDate: Mon Jul 31 22:39:09 2023 +0200
Revert "* libc/stdlib/mbtowc_r.c (__ascii_mbtowc): Disallow conversion of"
This reverts commit 2b77087a48ea56e77fca5aeab478c922f6473d7c.
For some reason lost in time, commit 2b77087a48ea5 introduced
Cygwin-specific code treating single byte characters outside the
portable character set as illegal chars. However, Cygwin was
always alone with this over-correct behaviour and it leads to
stuff like gnulib replacing functions defined in Cygwin with
their own implementation just due to that.
Revert this change, sans the changes to ChangeLog.
Fixes: 2b77087a48ea ("* libc/stdlib/mbtowc_r.c (__ascii_mbtowc): Disallow conversion of")
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diff:
---
newlib/libc/stdlib/mbtowc_r.c | 8 --------
newlib/libc/stdlib/wctomb_r.c | 4 ----
2 files changed, 12 deletions(-)
diff --git a/newlib/libc/stdlib/mbtowc_r.c b/newlib/libc/stdlib/mbtowc_r.c
index 01e596db8bde..cab8333d70df 100644
--- a/newlib/libc/stdlib/mbtowc_r.c
+++ b/newlib/libc/stdlib/mbtowc_r.c
@@ -36,14 +36,6 @@ __ascii_mbtowc (struct _reent *r,
if (n == 0)
return -2;
-#ifdef __CYGWIN__
- if ((wchar_t)*t >= 0x80)
- {
- _REENT_ERRNO(r) = EILSEQ;
- return -1;
- }
-#endif
-
*pwc = (wchar_t)*t;
if (*t == '\0')
diff --git a/newlib/libc/stdlib/wctomb_r.c b/newlib/libc/stdlib/wctomb_r.c
index 3081e9370271..5ea1e13e48a3 100644
--- a/newlib/libc/stdlib/wctomb_r.c
+++ b/newlib/libc/stdlib/wctomb_r.c
@@ -29,11 +29,7 @@ __ascii_wctomb (struct _reent *r,
if (s == NULL)
return 0;
-#ifdef __CYGWIN__
- if ((size_t)wchar >= 0x80)
-#else
if ((size_t)wchar >= 0x100)
-#endif
{
_REENT_ERRNO(r) = EILSEQ;
return -1;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-07-31 20:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-31 20:52 [newlib-cygwin/main] Revert "* libc/stdlib/mbtowc_r.c (__ascii_mbtowc): Disallow conversion of" Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).