public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Michael Frysinger <vapier@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin/users/vapier/wip] libgloss: msp430: delete outdated/wrong code
Date: Tue,  2 Jan 2024 04:36:15 +0000 (GMT)	[thread overview]
Message-ID: <20240102043615.E2DC5385842C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=025679996d1fb3bc985f5e22c6b111b5ef2093fd

commit 025679996d1fb3bc985f5e22c6b111b5ef2093fd
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Tue Dec 26 21:46:59 2023 -0500

    libgloss: msp430: delete outdated/wrong code
    
    The #if 0 & comment imply this code doesn't exist and is never used,
    except there's another #if Lrun_fini_array section below which *does*
    define this function, which makes this code comment confusing.  This
    seems to be a hold over of the cleanup of the minrt code in the old
    commit 884b05b54e4595433c85f8ca9820e88b4c723e38 ("MSP430: Remove
    .init/.fini sections").

Diff:
---
 libgloss/msp430/crt0.S | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/libgloss/msp430/crt0.S b/libgloss/msp430/crt0.S
index 88876cd48..c0b258f50 100644
--- a/libgloss/msp430/crt0.S
+++ b/libgloss/msp430/crt0.S
@@ -195,20 +195,6 @@ START_CRT_FUNC 0600 run_init_array
 END_CRT_FUNC	run_init_array
 #endif /* Lrun_init_array */
 
-;; FIXME: There are currently no program termination routines executed for
-;; msp430.
-#if 0
-#if Lrun_fini_array
-;; Ensure global C++ destructors in .fini_array are called on exit
-;; by registering __crt0_run_fini_array with atexit.
-START_CRT_FUNC 0700 register_fini_array
-
-	mov_	#__crt0_run_fini_array, R12
-	call_	#atexit
-
-END_CRT_FUNC	register_fini_array
-#endif /* Lrun_fini_array */
-#endif /* 0 */
 
 #if Lmain
 ;; This function is always included and calls main().

                 reply	other threads:[~2024-01-02  4:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240102043615.E2DC5385842C@sourceware.org \
    --to=vapier@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).